From: Pete Wyckoff <pw@padd.com>
To: Ryan Cumming <etaoins@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Teach git-completion about git p4
Date: Tue, 25 Sep 2012 20:48:38 -0400 [thread overview]
Message-ID: <20120926004838.GA29907@padd.com> (raw)
In-Reply-To: <1348264271-99395-1-git-send-email-rcumming@ea.com>
etaoins@gmail.com wrote on Fri, 21 Sep 2012 14:51 -0700:
> git p4 was moved out of contrib in 1.7.11 but it git-completion didn't
> know about it. Add git p4 completion based on the existing SVN
> completion. It covers all known subcommands and options except for the
> -/ option for clone which doesn't use the standard -- prefix.
Very nice, thank you. A couple nits.
> +_git_p4 ()
> +{
> + local subcommands="
> + clone sync rebase submit
> + "
> + local subcommand="$(__git_find_on_cmdline "$subcommands")"
> + if [ -z "$subcommand" ]; then
> + __gitcomp "$subcommands"
> + else
> + local common_opts="--git-dir= --verbose"
> + local sync_opts="
> + --branch= --detect-branches --changes-file=
It's --changesfile (no dash), weird, but true.
> + --silent --detect-labels --import-labels
> + --import-local --max-changes= --keep-path
> + --use-client-spec $common_opts
> + "
> + local clone_opts="
> + --destination= --bare $sync_opts
> + "
> + local submit_opts="
> + --origin= -M --preserve-user --export-labels
> + $common_opts
> + "
Very recently we added --dry-run and --prepare-p4-only and
--conflict to submit. Follow 8db3865^2 to see the patches
for those.
> + case "$subcommand,$cur" in
> + clone,--*)
> + __gitcomp "$clone_opts"
> + ;;
> + sync,--*)
> + __gitcomp "$sync_opts"
> + ;;
> + rebase,--*)
> + __gitcomp "$common_opts --import-labels"
This would be prettier if it had its own local rebase_opts.
> + submit,--*)
> + __gitcomp "$submit_opts"
> + ;;
> + submit,*)
> + __gitcomp "$(__git_refs)"
> + ;;
> + esac
> + fi
> +}
> +
> _git_pull ()
> {
> __git_complete_strategy && return
> --
> 1.7.12.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2012-09-26 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 21:51 [PATCH] Teach git-completion about git p4 Ryan Cumming
2012-09-24 16:12 ` Junio C Hamano
2012-09-26 0:48 ` Pete Wyckoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926004838.GA29907@padd.com \
--to=pw@padd.com \
--cc=etaoins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).