Git development
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>, "Johannes Sixt" <j6t@kdbg.org>
To: Git Mailing List <git@vger.kernel.org>
Subject: Re: Problem completing remotes when .git/remotes exits
Date: Wed, 26 Sep 2012 03:26:33 +0200	[thread overview]
Message-ID: <20120926012633.GE10144@goldbirke> (raw)
In-Reply-To: <20120926010938.GD10144@goldbirke>

On Wed, Sep 26, 2012 at 03:09:38AM +0200, SZEDER Gábor wrote:
> On Wed, Sep 26, 2012 at 01:00:45AM +0200, SZEDER Gábor wrote:
> > But then it got me thinking...  Notice how much effort we spend just
> > to get the list of remotes?  We could just run 'git remote' directly
> > instead...
> 
> Actually, we can't, because 'git remote' doesn't seem to list remotes
> stored under .git/remotes.  Is that intentional?

Looks like a bug, as it seems to have been lost in translation in
211c8968 (Make git-remote a builtin, 2008-02-29).

list_remote() in git-remote.perl looks for remotes in config and in
.git/remotes/, too.  The builtin implementation uses
remote.c:for_each_remote() from the start, which only looks at the
config.

      reply	other threads:[~2012-09-26  1:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 19:55 Problem completing remotes when .git/remotes exits Johannes Sixt
2012-09-25 23:00 ` SZEDER Gábor
2012-09-25 23:43   ` Junio C Hamano
2012-09-26 11:43     ` SZEDER Gábor
2012-09-26  1:09   ` SZEDER Gábor
2012-09-26  1:26     ` SZEDER Gábor, Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926012633.GE10144@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox