From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Conrad Irwin <conrad.irwin@gmail.com>,
Frans Klaver <fransklaver@gmail.com>,
git@vger.kernel.org, "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
Subject: Re: git 1.8.0.rc0.18.gf84667d trouble with "git commit -p file"
Date: Sun, 7 Oct 2012 18:25:03 -0400 [thread overview]
Message-ID: <20121007222502.GA3263@sigill.intra.peff.net> (raw)
In-Reply-To: <7vehl9q5uk.fsf@alter.siamese.dyndns.org>
On Sun, Oct 07, 2012 at 03:23:31PM -0700, Junio C Hamano wrote:
> >> Yeah, I agree with the reasoning. This is an unessential feature
> >> that is with the problem for a long time, so let's go the route #1
> >> first before we do anything else.
> >
> > OK. I think Conrad's patch takes us most of the way there. I had a few
> > minor comments, but I think another round should do it. Conrad?
>
> I'd rather want to see a patch that _only_ documents the current
> behaviour to unconfuse people first. I definitely do not want any
> patch that changes the command line parsing or any other behaviour
> change with problems that have to take time from reviewers to point
> them out mixed in it.
Sorry, I should have been more clear. I want to see a re-roll of only
the documentation bits of Conrad's patch, for which I had only minor
comments. The code part had major problems. :)
-Peff
next prev parent reply other threads:[~2012-10-07 22:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 14:20 git 1.8.0.rc0.18.gf84667d trouble with "git commit -p file" Horst H. von Brand
2012-10-05 19:55 ` Frans Klaver
2012-10-05 22:29 ` Junio C Hamano
2012-10-05 22:57 ` Jeff King
2012-10-06 6:26 ` Junio C Hamano
2012-10-06 13:12 ` Jeff King
2012-10-06 18:22 ` Junio C Hamano
2012-10-06 18:30 ` Jeff King
2012-10-06 18:32 ` Conrad Irwin
2012-10-06 19:07 ` Jeff King
2012-10-07 20:51 ` Junio C Hamano
2012-10-07 21:49 ` Jeff King
2012-10-07 22:23 ` Junio C Hamano
2012-10-07 22:25 ` Jeff King [this message]
2012-10-11 5:51 ` Conrad Irwin
2012-10-11 17:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007222502.GA3263@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=conrad.irwin@gmail.com \
--cc=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).