* [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed
@ 2012-10-11 20:40 Dylan Alex Simon
2012-10-12 15:43 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Dylan Alex Simon @ 2012-10-11 20:40 UTC (permalink / raw)
To: git, gitster
gitweb's feeds sometimes contained committer timestamps in the wrong timezone
due to a misspelling.
Signed-off-by: Dylan Simon <dylan@dylex.net>
---
gitweb/gitweb.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7f8c187..10ed9e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -8028,7 +8028,7 @@ sub git_feed {
%latest_commit = %{$commitlist[0]};
my $latest_epoch = $latest_commit{'committer_epoch'};
exit_if_unmodified_since($latest_epoch);
- %latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
+ %latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
}
print $cgi->header(
-type => $content_type,
--
1.7.10.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed
2012-10-11 20:40 [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed Dylan Alex Simon
@ 2012-10-12 15:43 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-10-12 15:43 UTC (permalink / raw)
To: Dylan Alex Simon; +Cc: git, Jakub Narębski
Dylan Alex Simon <dylan@dylex.net> writes:
> gitweb's feeds sometimes contained committer timestamps in the wrong timezone
> due to a misspelling.
>
> Signed-off-by: Dylan Simon <dylan@dylex.net>
> ---
This dates back to 6368d9f (gitweb: Always call parse_date with
timezone parameter, 2011-03-19) which was in 1.7.4.2 and has been
moved around without anybody noticing.
For any patch that is more complex, I would say "We've lived with
this bug for a long time and nobody was hurt enough to complain, so
it can wait until the next round", but I'll apply it directly to
'maint' because the fix is so trivially correct. Otherwise I'll
forget ;-)
Thanks.
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7f8c187..10ed9e5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8028,7 +8028,7 @@ sub git_feed {
> %latest_commit = %{$commitlist[0]};
> my $latest_epoch = $latest_commit{'committer_epoch'};
> exit_if_unmodified_since($latest_epoch);
> - %latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
> + %latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
> }
> print $cgi->header(
> -type => $content_type,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-12 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-11 20:40 [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed Dylan Alex Simon
2012-10-12 15:43 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).