From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Chris Rorvick <chris@rorvick.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-cvsimport: allow author-specific timezones
Date: Tue, 16 Oct 2012 02:31:52 -0400 [thread overview]
Message-ID: <20121016063152.GB22941@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4nlvulc2.fsf@alter.siamese.dyndns.org>
On Mon, Oct 15, 2012 at 08:50:21PM -0700, Junio C Hamano wrote:
> Chris Rorvick <chris@rorvick.com> writes:
>
> > It occurred to me that the success of the unit test depends on the
> > host platform's zoneinfo database. I think this problem is inherent
> > with this functionality. Should the unit test attempt to detect
> > support for the used timezones and short circuit if this fails? Not
> > sure exactly how I'd do this, but wondering if it's worth thinking
> > about.
>
> Yeah, that did indeed cross my mind.
>
> You could say TZ=QST6QDT or something silly like that but that in
> turn has to assume your tzset() is POSIX.1 compliant anyway.
We use EST5 in t0006 (it was originally just "EST" but IRIX complained).
It's been in the test suite for two years without a problem, so it may
be simple and safe enough to just use that.
-Peff
next prev parent reply other threads:[~2012-10-16 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 0:30 [PATCH] git-cvsimport: allow author-specific timezones Chris Rorvick
2012-10-15 17:40 ` Junio C Hamano
2012-10-16 2:26 ` Chris Rorvick
2012-10-16 3:50 ` Junio C Hamano
2012-10-16 6:31 ` Jeff King [this message]
2012-10-16 15:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016063152.GB22941@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chris@rorvick.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).