From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3] status: refactor output format to represent "default" and add --long
Date: Thu, 18 Oct 2012 16:26:47 -0400 [thread overview]
Message-ID: <20121018202647.GA31093@sigill.intra.peff.net> (raw)
In-Reply-To: <1350569750-26304-1-git-send-email-pclouds@gmail.com>
On Thu, Oct 18, 2012 at 09:15:50PM +0700, Nguyen Thai Ngoc Duy wrote:
> On Thu, Oct 18, 2012 at 9:03 AM, Jeff King <peff@peff.net> wrote:
> > I think that is fine to split it like this, but you would want to update
> > the commit message above. Probably just remove those two cases and say
> > something like:
> >
> > Note that you cannot actually trigger STATUS_FORMAT_LONG, as we do
> > not yet have "--long"; that will come in a follow-on patch.
> >
> > And then move the reasoning for how "--long" works with each case into
> > the commit message of the next patch.
>
> Nope, it's hard to split the explanation in two (at least to me),
> which may mean that the split does not make sense.
Yeah, that was the same place that I had difficulty when writing the
original. This version looks OK to me.
-Peff
next prev parent reply other threads:[~2012-10-18 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 16:22 [PATCH] status: add --long for default format Nguyễn Thái Ngọc Duy
2012-10-16 17:22 ` Jeff King
2012-10-16 18:32 ` Jeff King
2012-10-18 1:57 ` [PATCH v2 1/2] status: refactor output format to represent "default" Nguyễn Thái Ngọc Duy
2012-10-18 1:58 ` [PATCH v2 2/2] status: add --long for default format Nguyễn Thái Ngọc Duy
2012-10-18 2:03 ` [PATCH v2 1/2] status: refactor output format to represent "default" Jeff King
2012-10-18 14:15 ` [PATCH v3] status: refactor output format to represent "default" and add --long Nguyễn Thái Ngọc Duy
2012-10-18 20:26 ` Jeff King [this message]
2012-10-18 21:16 ` Junio C Hamano
2012-10-18 21:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018202647.GA31093@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).