From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] fix 'make test' for HP NonStop Date: Thu, 25 Oct 2012 06:49:00 -0400 Message-ID: <20121025104900.GA6363@sigill.intra.peff.net> References: <001e01cdb061$c25f6380$471e2a80$@schmitz-digital.de> <20121025095826.GM8390@sigill.intra.peff.net> <002e01cdb29a$893593f0$9ba0bbd0$@schmitz-digital.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org To: Joachim Schmitz X-From: git-owner@vger.kernel.org Thu Oct 25 12:49:27 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TRL05-00019b-BF for gcvg-git-2@plane.gmane.org; Thu, 25 Oct 2012 12:49:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759355Ab2JYKtF (ORCPT ); Thu, 25 Oct 2012 06:49:05 -0400 Received: from 75-15-5-89.uvs.iplsin.sbcglobal.net ([75.15.5.89]:56131 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759322Ab2JYKtD (ORCPT ); Thu, 25 Oct 2012 06:49:03 -0400 Received: (qmail 8075 invoked by uid 107); 25 Oct 2012 10:49:42 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Thu, 25 Oct 2012 06:49:42 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 25 Oct 2012 06:49:00 -0400 Content-Disposition: inline In-Reply-To: <002e01cdb29a$893593f0$9ba0bbd0$@schmitz-digital.de> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Oct 25, 2012 at 12:21:44PM +0200, Joachim Schmitz wrote: > > > + # for 'make test' > > > + # some test don't work with /bin/diff, some fail with /bin/tar > > > + # some need bash, and some need ${prefix}/bin in PATH first > > > + SHELL_PATH=${prefix}/bin/bash > > > + SANE_TOOL_PATH=${prefix}/bin > > > > This feels a little too specific to go in our Makefile. Do we have any > > reason to think that where you are installing git is going to be the > > same place you have bash and other sane tools? Wouldn't this mean that > > things work when you run "make" but mysteriously break when you run > > "make prefix=/my/local/install/of/git"? > > Well, "make" won't break (I think), but "make test" very well might. Sure. > Well, so far all OpenSource packages ported to HP NonStop (at least > the ones on ituglib.connect-community.org) use prefix=/usr/local and > there is no intention to change that. But then I would think using /usr/local would be the sane thing to put there, if that is the closest to "standard" for your platform. If there is not a standard, then I think we are better off leaving it blank and letting people do the right thing for their system (including packagers who are building for other people). -Peff