From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org, bdwalton@gmail.com, bosch@adacore.com,
brian@gernhardtsoftware.com, robin.rosenberg@dewire.com
Subject: Re: [PATCH] Fix t9200 on case insensitive file systems
Date: Sun, 28 Oct 2012 07:10:53 -0400 [thread overview]
Message-ID: <20121028111053.GC11434@sigill.intra.peff.net> (raw)
In-Reply-To: <201210261818.25620.tboegi@web.de>
On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote:
> t9200 defines $CVSROOT where cvs should init its repository
> $CVSROOT is set to $PWD/cvsroot.
> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT
>
> "cvs init" (e.g. version 1.11.23) checks if the last element of the path is
> "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.
>
> For such a $CVSROOT cvs refuses to init a repository here:
> "Cannot initialize repository under existing CVSROOT:
>
> On a case insenstive file system cvsroot and CVSROOT are the same directories
> and t9200 fails.
>
> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot
Wouldn't tmp/cvsroot have the same problem, since the basename is still
cvsroot?
> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
> index b59be9a..69934b2 100755
> --- a/t/t9200-git-cvsexportcommit.sh
> +++ b/t/t9200-git-cvsexportcommit.sh
> @@ -19,7 +19,7 @@ then
> test_done
> fi
>
> -CVSROOT=$PWD/cvsroot
> +CVSROOT=$PWD/tmpcvsroot
Ah, but here you do something different, which makes sense. Should I
tweak the commit message?
-Peff
next prev parent reply other threads:[~2012-10-28 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 16:18 [PATCH] Fix t9200 on case insensitive file systems Torsten Bögershausen
2012-10-27 21:36 ` Ben Walton
2012-10-28 11:10 ` Jeff King [this message]
2012-10-28 15:28 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028111053.GC11434@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bdwalton@gmail.com \
--cc=bosch@adacore.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).