From: Jeff King <peff@peff.net>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: "Andreas Schwab" <schwab@linux-m68k.org>,
"Bojan Petrović" <bojan85@gmail.com>,
git@vger.kernel.org
Subject: Re: Mistake in git-reset documentation
Date: Mon, 29 Oct 2012 01:38:20 -0400 [thread overview]
Message-ID: <20121029053820.GC30186@sigill.intra.peff.net> (raw)
In-Reply-To: <20121028141327.GB16686@shrek.podlesie.net>
On Sun, Oct 28, 2012 at 03:13:27PM +0100, Krzysztof Mazur wrote:
> The --mixed mode is also described as second mode, and saying that --mixed
> is default earlier may save some time wasted on reading --soft
> description.
>
> There is also small inconsequence in what <mode> is, just "mixed" or
> "--mixed".
Yeah, agreed on both.
> -- >8 --
> Subject: [PATCH] doc: git-reset: make "<mode>" optional
>
> The git-reset's "<mode>" is an optional argument, however it was
> documented as required.
>
> The "<mode>" is documented as one of: --soft, --mixed, --hard, --merge
> or --keep, so "<mode>" should be used instead of "--<mode>".
>
> Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Thanks, this looks good to me.
-Peff
prev parent reply other threads:[~2012-10-29 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 11:21 Mistake in git-reset documentation Bojan Petrović
2012-10-28 8:36 ` Krzysztof Mazur
2012-10-28 9:32 ` Bojan Petrović
2012-10-28 11:07 ` Jeff King
2012-10-28 13:39 ` Andreas Schwab
2012-10-28 13:46 ` Jeff King
2012-10-28 14:13 ` Krzysztof Mazur
2012-10-29 5:38 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029053820.GC30186@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bojan85@gmail.com \
--cc=git@vger.kernel.org \
--cc=krzysiek@podlesie.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).