git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
	Daniel Barkalow <barkalow@iabervon.org>,
	Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH v4 00/13] New remote-hg helper
Date: Mon, 29 Oct 2012 18:06:04 -0400	[thread overview]
Message-ID: <20121029220604.GA21712@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s1SLpNpbjRXF6QHrOTO=_1=wjPo1_kV3jZV-HXOYXPbnQ@mail.gmail.com>

On Mon, Oct 29, 2012 at 11:02:31PM +0100, Felipe Contreras wrote:

> > If remote-hg is going to live in contrib, it probably makes sense to
> > have its tests live there, too, like subtree.
> 
> Probably, I'll check that option.
> 
> But eventually I think it should be installed by default, unless
> somebody can come up for a reason not to. For now contrib might be OK.

I would one day like to have it as part of the main distribution, too,
but it would be nice to prove its worth in the field for a while first.
I especially would like to find out how it compares in practice with the
work that is in msysgit.

> > It means less test exposure, but the robustness of the tests does
> > not have to be as high.  You could also have no tests, but since you
> > have them, it seems silly not to include them. People know that
> > items in contrib/ may not be as mature as the rest of git.
> 
> Yeah, it's only a matter of figuring out how to run them.

Subtree seems to copy substantial parts of t/Makefile, but I suspect you
could get away with just using an "include". I'd also be OK with just
including a test script that pulls in test-lib.sh, and letting people
run it manually (the Makefile infrastructure is really about running a
lot of tests, but if there's only one script, it's not so hard).

-Peff

  reply	other threads:[~2012-10-29 22:06 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28  3:54 [PATCH v4 00/13] New remote-hg helper Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 01/13] Add new remote-hg transport helper Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 02/13] remote-hg: add support for bookmarks Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 03/13] remote-hg: add support for pushing Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 04/13] remote-hg: add support for remote pushing Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 05/13] remote-hg: add support to push URLs Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 06/13] remote-hg: make sure the encoding is correct Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 07/13] remote-hg: match hg merge behavior Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 08/13] remote-hg: add support for hg-git compat mode Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 09/13] remote-hg: add compat for hg-git author fixes Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 10/13] remote-hg: fake bookmark when there's none Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 11/13] remote-hg: add support for fake remote Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 12/13] remote-hg: add tests to compare with hg-git Felipe Contreras
2012-10-28  3:54 ` [PATCH v4 13/13] remote-hg: add extra author test Felipe Contreras
2012-10-29  8:50 ` [PATCH v4 00/13] New remote-hg helper Jeff King
2012-10-29 14:56   ` Felipe Contreras
2012-10-29 21:26     ` Jeff King
2012-10-29 21:47       ` Felipe Contreras
2012-10-29 21:56         ` Jeff King
2012-10-29 22:02           ` Felipe Contreras
2012-10-29 22:06             ` Jeff King [this message]
2012-10-30 17:18               ` Felipe Contreras
2012-10-30 17:20           ` Johannes Schindelin
2012-10-30 18:10             ` Felipe Contreras
2012-10-30 19:33               ` Johannes Schindelin
2012-10-30 20:15                 ` Felipe Contreras
2012-10-31  9:30                   ` Michael J Gruber
2012-10-31 10:27                     ` Jeff King
2012-10-31 15:58                       ` Felipe Contreras
2012-10-31 18:20                       ` Johannes Schindelin
2012-10-31 18:41                         ` Felipe Contreras
2012-10-31 18:59                           ` Jonathan Nieder
2012-10-31 19:24                             ` Felipe Contreras
2012-10-31 20:28                               ` Lack of netiquette, was " Johannes Schindelin
2012-10-31 20:37                                 ` Felipe Contreras
2012-11-01  1:32                                 ` Junio C Hamano
2012-11-01  2:58                                   ` Felipe Contreras
2012-11-01 13:46                                     ` René Scharfe
2012-11-01 14:18                                       ` Tomas Carnecky
2012-11-01 14:18                                       ` Martin Langhoff
2012-11-01 14:34                                       ` Felipe Contreras
2012-11-01 14:47                                         ` Martin Langhoff
2012-11-01 17:13                                           ` Felipe Contreras
2012-11-02  9:38                                       ` Andreas Ericsson
2012-11-02 11:03                                         ` Michael J Gruber
2012-11-02 16:09                                           ` Felipe Contreras
2012-11-05  9:25                                             ` Michael J Gruber
2012-11-05 15:22                                               ` Felipe Contreras
2012-11-05 15:58                                                 ` Felipe Contreras
2012-11-05 16:00                                                 ` Michael J Gruber
2012-11-05 16:15                                                   ` Felipe Contreras
2012-11-01 20:46                                   ` Jonathan Nieder
2012-10-31 23:14                               ` Daniel Barkalow
2012-11-01  2:46                                 ` Felipe Contreras
2012-11-01  1:41                         ` Junio C Hamano
2012-11-01  2:54                           ` Felipe Contreras
2012-10-31 15:39                     ` Felipe Contreras
2012-10-31 15:55                       ` Michael J Gruber
2012-10-31 16:11                         ` Felipe Contreras
2012-11-02 14:46                           ` Jeff King
2012-11-02 18:39                             ` Felipe Contreras
2012-11-02 19:20                               ` Felipe Contreras
2012-11-04  2:28                                 ` Felipe Contreras
2012-11-02 23:18                               ` Thomas Adam
2012-11-02 23:52                                 ` Felipe Contreras
2012-10-31 18:04                         ` Felipe Contreras
2012-10-31 19:47                           ` Felipe Contreras
2012-11-01  4:08                             ` Felipe Contreras
2012-11-02 14:48                               ` Jeff King
2012-11-02 16:41                                 ` Felipe Contreras
2012-11-02 18:01                                   ` Felipe Contreras
2012-11-05 14:13                                     ` Michael J Gruber
2012-11-05 15:36                                       ` Felipe Contreras
2012-11-01  1:22                       ` Junio C Hamano
2012-11-01  2:50                         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121029220604.GA21712@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=felipe.contreras@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ilari.liusvaara@elisanet.fi \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).