From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jeff King" <peff@peff.net>, "Ævar Arnfjörð" <avarab@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>
Subject: Re: [PATCH] test-lib: avoid full path to store test results
Date: Tue, 30 Oct 2012 19:13:18 -0700 [thread overview]
Message-ID: <20121031021318.GB15167@elie.Belkin> (raw)
In-Reply-To: <CAMP44s1xAeW2QZsNwRVRx+DEhYVVdiKbw-y-aNuo6unuv7pYZQ@mail.gmail.com>
Felipe Contreras wrote:
> It's all fun and games to write explanations for things, but it's not
> that easy when you want those explanations to be actually true, and
> corrent--you have to spend time to make sure of that.
That's why it's useful for the patch submitter to write them, asking
for help when necessary.
As a bonus, it helps reviewers understand the effect of the patch.
Bugs averted!
[...]
> Either way, if obvious fixes that are one-liners require an essay for
> you, I give up.
I guess it is fair to call a reasonable subject line plus a couple of
sentences an essay. Yes, obvious fixes especially require that, since
the bug caused by an obvious fix is one of the worst kinds.
next prev parent reply other threads:[~2012-10-31 2:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 4:12 [PATCH] test-lib: avoid full path to store test results Felipe Contreras
2012-10-30 4:28 ` Jeff King
2012-10-30 4:39 ` Felipe Contreras
2012-10-30 4:46 ` Jonathan Nieder
2012-10-30 16:02 ` Felipe Contreras
2012-10-31 1:27 ` Jonathan Nieder
2012-10-31 1:59 ` Felipe Contreras
2012-10-31 2:13 ` Jonathan Nieder [this message]
2012-10-31 2:28 ` Felipe Contreras
2012-10-31 18:02 ` Johannes Sixt
2012-10-31 18:28 ` Felipe Contreras
2012-11-02 13:17 ` Jeff King
2012-11-02 15:17 ` Felipe Contreras
2012-11-02 15:20 ` Jeff King
2012-10-30 6:58 ` Elia Pinto
2012-10-30 7:01 ` Jonathan Nieder
2012-10-30 22:17 ` Elia Pinto
2012-10-31 9:05 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031021318.GB15167@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox