From: Jeff King <peff@peff.net>
To: shawn wilson <ag4ve.us@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, git@vger.kernel.org
Subject: Re: change symlink
Date: Wed, 31 Oct 2012 09:44:32 -0400 [thread overview]
Message-ID: <20121031134432.GA24518@sigill.intra.peff.net> (raw)
In-Reply-To: <20121031123057.GE30879@sigill.intra.peff.net>
On Wed, Oct 31, 2012 at 08:30:57AM -0400, Jeff King wrote:
> Something like this seems to fix it for me, but I am not sure if that
> would affect other callers.
> [...]
> + return !is_dir || !S_ISGITLINK(istate->cache[pos]->ce_mode);
That's completely wrong, of course. It should be:
return is_dir && !S_ISGITLINK(...);
(we found an index entry, so if it isn't a directory, then we know that
it is not untracked, and should return 0).
With that, we at least pass the test suite.
-Peff
prev parent reply other threads:[~2012-10-31 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 21:07 change symlink shawn wilson
2012-10-30 21:19 ` Andreas Schwab
2012-10-30 21:24 ` shawn wilson
2012-10-30 21:35 ` Andreas Schwab
2012-10-30 21:42 ` shawn wilson
2012-10-30 21:50 ` Andreas Schwab
2012-10-30 22:03 ` shawn wilson
2012-10-30 22:09 ` Andreas Schwab
2012-10-30 22:22 ` shawn wilson
2012-10-31 12:05 ` Jeff King
2012-10-31 12:30 ` Jeff King
2012-10-31 13:44 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031134432.GA24518@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ag4ve.us@gmail.com \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).