From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, nisse@lysator.liu.se
Subject: Re: [PATCH] Document 'git commit --no-edit' explicitly
Date: Fri, 2 Nov 2012 07:53:35 -0400 [thread overview]
Message-ID: <20121102115335.GA2598@sigill.intra.peff.net> (raw)
In-Reply-To: <1351852770-13897-1-git-send-email-Matthieu.Moy@imag.fr>
On Fri, Nov 02, 2012 at 11:39:30AM +0100, Matthieu Moy wrote:
> I was tempted to merge the paragraph with --edit::, but I thought this
> may add confusion. The use-cases for --edit and --no-edit are really
> different so I went for a separate paragraph, right below the --edit one.
Yeah, usually I think it would be better to keep the positive and
negative forms together, but the way you have done it does seem a lot
more clear to me. I think it is because the default flips based on other
options. So you would be stuck writing something like:
-e, --edit::
Edit the commit message using `$EDITOR`. This is the default
unless the `-F`, `-m`, or `-C` options are used; in those
cases, `-e` or `--edit` can be used to invoke the editor.
Likewise, `--no-edit` can be used to suppress the editor when
using an existing commit message. For example, `git commit
--amend --no-edit` amends a commit without changing its commit
message.
Your split reads much better, IMHO.
Thanks.
-Peff
prev parent reply other threads:[~2012-11-02 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 9:26 Wishlist: git commit --no-edit Niels Möller
2012-11-02 9:42 ` Matthieu Moy
2012-11-02 9:59 ` Jeff King
[not found] ` <CACnwZYe-za3Q0qvkfQ=qatB1-8eLUFA6ZzfS41yeqrV=8rVzGA@mail.gmail.com>
2012-11-02 12:45 ` Jeff King
2012-11-02 10:07 ` Niels Möller
2012-11-02 10:39 ` [PATCH] Document 'git commit --no-edit' explicitly Matthieu Moy
2012-11-02 11:24 ` Niels Möller
2012-11-02 11:29 ` Matthieu Moy
2012-11-02 11:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102115335.GA2598@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=nisse@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).