From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Johannes Sixt" <j6t@kdbg.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: [PATCH] test-lib: avoid full path to store test results
Date: Fri, 2 Nov 2012 09:17:26 -0400 [thread overview]
Message-ID: <20121102131726.GC2598@sigill.intra.peff.net> (raw)
In-Reply-To: <509167C8.6090600@kdbg.org>
On Wed, Oct 31, 2012 at 07:02:48PM +0100, Johannes Sixt wrote:
> Am 31.10.2012 03:28, schrieb Felipe Contreras:
> > On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> >> Felipe Contreras wrote:
> >>
> >>> It's all fun and games to write explanations for things, but it's not
> >>> that easy when you want those explanations to be actually true, and
> >>> corrent--you have to spend time to make sure of that.
> >>
> >> That's why it's useful for the patch submitter to write them, asking
> >> for help when necessary.
> >>
> >> As a bonus, it helps reviewers understand the effect of the patch.
> >> Bugs averted!
> >
> > Yeah, that would be nice. Too bad I don't have that information, and
> > have _zero_ motivation to go and get it for you.
>
> Just to clarify: That information is not just for Jonathan, but for
> everyone on this list and those who dig the history a year down the
> road. Contributors who have _zero_ motiviation to find out that
> information are not welcome here because they cause friction and take
> away time from many others for _zero_ gain.
And me, who is trying to figure out what to do with this patch. It is
presented on its own, outside of a series, with only the description "no
reason not to do this". But AFAICT, it is _required_ for the tests in
the remote-hg series to work. Isn't that kind of an important
motivation?
Yet it is not in the commit message, nor does the remote-hg series
indicate that it should be built on top. Or am I wrong that the one is
dependent on the other?
-Peff
next prev parent reply other threads:[~2012-11-02 13:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 4:12 [PATCH] test-lib: avoid full path to store test results Felipe Contreras
2012-10-30 4:28 ` Jeff King
2012-10-30 4:39 ` Felipe Contreras
2012-10-30 4:46 ` Jonathan Nieder
2012-10-30 16:02 ` Felipe Contreras
2012-10-31 1:27 ` Jonathan Nieder
2012-10-31 1:59 ` Felipe Contreras
2012-10-31 2:13 ` Jonathan Nieder
2012-10-31 2:28 ` Felipe Contreras
2012-10-31 18:02 ` Johannes Sixt
2012-10-31 18:28 ` Felipe Contreras
2012-11-02 13:17 ` Jeff King [this message]
2012-11-02 15:17 ` Felipe Contreras
2012-11-02 15:20 ` Jeff King
2012-10-30 6:58 ` Elia Pinto
2012-10-30 7:01 ` Jonathan Nieder
2012-10-30 22:17 ` Elia Pinto
2012-10-31 9:05 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102131726.GC2598@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).