From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 1/4] strbuf_split_buf(): use ALLOC_GROW() Date: Sun, 4 Nov 2012 06:41:01 -0500 Message-ID: <20121104114101.GA336@sigill.intra.peff.net> References: <1352011614-29334-1-git-send-email-mhagger@alum.mit.edu> <1352011614-29334-2-git-send-email-mhagger@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Junio C Hamano , git@vger.kernel.org To: Michael Haggerty X-From: git-owner@vger.kernel.org Sun Nov 04 12:41:36 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUya3-00016g-Vc for gcvg-git-2@plane.gmane.org; Sun, 04 Nov 2012 12:41:32 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302Ab2KDLlL (ORCPT ); Sun, 4 Nov 2012 06:41:11 -0500 Received: from 75-15-5-89.uvs.iplsin.sbcglobal.net ([75.15.5.89]:56493 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753170Ab2KDLlJ (ORCPT ); Sun, 4 Nov 2012 06:41:09 -0500 Received: (qmail 23050 invoked by uid 107); 4 Nov 2012 11:41:51 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Sun, 04 Nov 2012 06:41:51 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Sun, 04 Nov 2012 06:41:02 -0500 Content-Disposition: inline In-Reply-To: <1352011614-29334-2-git-send-email-mhagger@alum.mit.edu> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Nov 04, 2012 at 07:46:51AM +0100, Michael Haggerty wrote: > Use ALLOC_GROW() rather than inline code to manage memory in > strbuf_split_buf(). Rename "pos" to "nr" because it better describes > the use of the variable and it better conforms to the "ALLOC_GROW" > idiom. I suspect this was not used originally because ALLOC_GROW relies on alloc_nr, which does fast growth early on. At (x+16)*3/2, we end up with 24 slots for the first allocation. We are typically splitting 1 or 2 values. It probably doesn't make a big difference in practice, though, as we're talking about wasting less than 200 bytes on a 64-bit platform, and we do not tend to keep large numbers of split lists around. -Peff