From: Jeff King <peff@peff.net>
To: Alex Linden Levy <lindenle@gmail.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Add rm to submodule command.
Date: Sun, 4 Nov 2012 08:43:24 -0500 [thread overview]
Message-ID: <20121104134324.GA31623@sigill.intra.peff.net> (raw)
In-Reply-To: <1351877171-3176-1-git-send-email-lindenle@gmail.com>
On Fri, Nov 02, 2012 at 10:26:11AM -0700, Alex Linden Levy wrote:
> This change removes the config entries in .gitmodules and adds it.
> ---
Signoff?
> git-submodule.sh | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 61 insertions(+), 1 deletion(-)
No documentation or tests?
> diff --git a/git-submodule.sh b/git-submodule.sh
> index ab6b110..29d950f 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
I'd defer to submodule experts on whether the steps to 'rm' the
submodule make sense. Jens?
-Peff
next prev parent reply other threads:[~2012-11-04 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 17:26 [PATCH] Add rm to submodule command Alex Linden Levy
2012-11-04 13:43 ` Jeff King [this message]
2012-11-04 14:29 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104134324.GA31623@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lindenle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).