From: Jeff King <peff@peff.net>
To: rh <richard_hubbe11@lavabit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb.perl: fix %highlight_ext mappings
Date: Sun, 4 Nov 2012 08:48:41 -0500 [thread overview]
Message-ID: <20121104134841.GC31623@sigill.intra.peff.net> (raw)
In-Reply-To: <20121102141226.643a96e61b8bf383428c5287@lavabit.com>
On Fri, Nov 02, 2012 at 02:12:26PM -0700, rh wrote:
> The previous change created a dictionary of one-to-one elements when
> the intent was to map mutliple related types to one main type.
> e.g. bash, ksh, zsh, sh all map to sh since they share similar syntax
> This makes the mapping as the original change intended.
>
> Signed-off-by: rh <richard_hubbe11@lavabit.com>
>
> diff --git a/gitweb.cgi.orig b/gitweb.cgi
> index 060db27..155b238 100755
> --- a/gitweb.cgi.orig
> +++ b/gitweb.cgi
Close on the format. There should be a "---" after the sign-off but
before the diff. I can fix it up locally (and the patch looks good to
me).
However, one final thing: the point of the sign-off is to indicate that
you are legally OK to release the code under the DCO. For that reason,
we usually require a real name (not rh). I can guess at your real name
from your email, but I'd rather be sure. Can you provide it?
-Peff
next prev parent reply other threads:[~2012-11-04 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 21:12 [PATCH] gitweb.perl: fix %highlight_ext mappings rh
2012-11-04 13:48 ` Jeff King [this message]
2012-11-04 17:44 ` rh
-- strict thread matches above, loose matches on Subject: below --
2012-11-04 17:45 rh
2012-11-08 18:01 ` Jeff King
2012-11-08 18:36 ` rh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104134841.GC31623@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=richard_hubbe11@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).