From: Jeff King <peff@peff.net>
To: Phil Pennock <phil@apcera.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] gitweb: make remote_heads config setting work.
Date: Thu, 8 Nov 2012 11:56:48 -0500 [thread overview]
Message-ID: <20121108165648.GG15560@sigill.intra.peff.net> (raw)
In-Reply-To: <20121105235047.GA78156@redoubt.spodhuis.org>
On Mon, Nov 05, 2012 at 06:50:47PM -0500, Phil Pennock wrote:
> Git configuration items can not contain underscores in their name; the
> 'remote_heads' feature can not be enabled on a per-repository basis with
> that name.
>
> This changes the git-config option to be `gitweb.remoteheads` but does
> not change the gitweb.conf option, to avoid backwards compatibility
> issues. We strip underscores from keys before looking through
> git-config output for them.
Makes sense. Thanks for considering the backwards compatibility angle.
Hopefully we can avoid adding names with underscores in the future, but I
think the mapping of "remote_head -> remotehead" is obvious enough that
we do not need to worry about deprecating and replacing the old name.
-Peff
next prev parent reply other threads:[~2012-11-08 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 23:50 [PATCH] gitweb: make remote_heads config setting work Phil Pennock
2012-11-08 16:56 ` Jeff King [this message]
2012-11-09 4:40 ` Junio C Hamano
2012-11-09 16:37 ` Jeff King
2012-11-20 22:21 ` Re* " Junio C Hamano
2012-11-21 19:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108165648.GG15560@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phil@apcera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).