From: Jeff King <peff@peff.net>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org, Chris Goard <cgoard@gmail.com>
Subject: Re: [PATCH] git p4: RCS expansion should not span newlines
Date: Thu, 8 Nov 2012 12:47:27 -0500 [thread overview]
Message-ID: <20121108174727.GJ15560@sigill.intra.peff.net> (raw)
In-Reply-To: <20121104220402.GA9160@padd.com>
On Sun, Nov 04, 2012 at 05:04:02PM -0500, Pete Wyckoff wrote:
> This bug was introduced in cb585a9 (git-p4: keyword
> flattening fixes, 2011-10-16). The newline character
> is indeed special, and $File$ expansions should not try
> to match across multiple lines.
>
> Based-on-patch-by: Chris Goard <cgoard@gmail.com>
> Signed-off-by: Pete Wyckoff <pw@padd.com>
Thanks, I'll queue this for 'maint'. Seems obviously correct to me.
-Peff
prev parent reply other threads:[~2012-11-08 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACtYWOYOSxmogJHy70McsRVf0m2PVuu=q+pDZ2-gAza7vpeEiA@mail.gmail.com>
2012-11-04 22:04 ` [PATCH] git p4: RCS expansion should not span newlines Pete Wyckoff
2012-11-08 17:47 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108174727.GJ15560@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cgoard@gmail.com \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).