From: Jeff King <peff@peff.net>
To: Chris Rorvick <chris@rorvick.com>
Cc: git@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Angelo Borsotti <angelo.borsotti@gmail.com>,
Philip Oakley <philipoakley@iee.org>,
Johannes Sixt <j6t@kdbg.org>,
Kacper Kornet <draenog@pld-linux.org>
Subject: Re: [PATCH v2 1/5] push: return reject reasons via a mask
Date: Fri, 9 Nov 2012 13:35:35 -0500 [thread overview]
Message-ID: <20121109183535.GA22164@sigill.intra.peff.net> (raw)
In-Reply-To: <1352084908-32333-2-git-send-email-chris@rorvick.com>
On Sun, Nov 04, 2012 at 09:08:24PM -0600, Chris Rorvick wrote:
> Pass all rejection reasons back from transport_push(). The logic is
> simpler and more flexible with regard to providing useful feedback.
> [...]
>
> void transport_print_push_status(const char *dest, struct ref *refs,
> - int verbose, int porcelain, int *nonfastforward);
> + int verbose, int porcelain, unsigned int *reject_mask);
You missed updating one call-site of this function in
builtin/send-pack.c (gcc -Wall will now complain of the signed/unsigned
mismatch in the passed-in pointer).
-Peff
next prev parent reply other threads:[~2012-11-09 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 3:08 [PATCH v2 0/5] push: update remote tags only with force Chris Rorvick
2012-11-05 3:08 ` [PATCH v2 1/5] push: return reject reasons via a mask Chris Rorvick
2012-11-09 18:35 ` Jeff King [this message]
2012-11-05 3:08 ` [PATCH v2 2/5] push: add advice for rejected tag reference Chris Rorvick
2012-11-05 3:08 ` [PATCH v2 3/5] push: flag updates Chris Rorvick
2012-11-05 3:08 ` [PATCH v2 4/5] push: flag updates that require force Chris Rorvick
2012-11-05 3:08 ` [PATCH v2 5/5] push: update remote tags only with force Chris Rorvick
2012-11-09 18:38 ` [PATCH v2 0/5] " Jeff King
2012-11-10 1:15 ` Chris Rorvick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109183535.GA22164@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=angelo.borsotti@gmail.com \
--cc=chris@rorvick.com \
--cc=draenog@pld-linux.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).