git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 1/4] remote-hg: add missing config for basic tests
Date: Mon, 12 Nov 2012 15:32:07 -0500	[thread overview]
Message-ID: <20121112203207.GF4623@sigill.intra.peff.net> (raw)
In-Reply-To: <1352742068-15346-2-git-send-email-felipe.contreras@gmail.com>

On Mon, Nov 12, 2012 at 06:41:05PM +0100, Felipe Contreras wrote:

> From: Ramkumar Ramachandra <artagnon@gmail.com>
> 
> 'hg commit' fails otherwise in some versiosn of mercurial because of

s/versiosn/versions/

> +setup () {
> +	(
> +	echo "[ui]"
> +	echo "username = A U Thor <author@example.com>"
> +	) >> "$HOME"/.hgrc
> +}

This makes sense, but I wonder if we should use something different from
the git author ident set up by the test scripts, just to double check
that we do not have any bugs in confusing the two during the import.

Something like "H G Wells <wells@example.com>" would work, and satisfies
my deep-seated desire for bad puns.

-Peff

  reply	other threads:[~2012-11-12 20:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 17:41 [PATCH 0/4] remote-hg: small fixes Felipe Contreras
2012-11-12 17:41 ` [PATCH 1/4] remote-hg: add missing config for basic tests Felipe Contreras
2012-11-12 20:32   ` Jeff King [this message]
2012-11-13  3:46     ` Felipe Contreras
2012-11-13  5:48       ` Jeff King
2012-11-13  7:12         ` Felipe Contreras
2012-11-12 17:41 ` [PATCH 2/4] remote-hg: fix compatibility with older versions of hg Felipe Contreras
2012-11-13  5:25   ` Ramkumar Ramachandra
2012-11-13  7:11     ` Felipe Contreras
2012-11-12 17:41 ` [PATCH 3/4] remote-hg: try the 'tip' if no checkout present Felipe Contreras
2012-11-12 17:41 ` [PATCH 4/4] remote-hg: avoid bad refs Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112203207.GF4623@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=artagnon@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).