From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Jean-Jacques Lafay" <jeanjacques.lafay@gmail.com>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
msysgit@googlegroups.com, "Git List" <git@vger.kernel.org>,
"Philip Oakley" <philipoakley@iee.org>
Subject: Re: Re: [PATCH] git tag --contains : avoid stack overflow
Date: Mon, 12 Nov 2012 23:05:41 -0500 [thread overview]
Message-ID: <20121113040541.GA9439@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1211130400030.13573@bonsai2>
On Tue, Nov 13, 2012 at 04:01:11AM +0000, Johannes Schindelin wrote:
> > Note that name-rev will produce wrong answers in the face of clock skew.
> > And I think that you even wrote that code. :)
>
> IIRC the cute code to short-circuit using the date is not from me. If it
> is, I am very ashamed.
Sorry, but it was:
$ git blame -L'/commit->date < cutoff/',+1 builtin/name-rev.c
bd321bcc name-rev.c (Johannes Schindelin 2005-10-26 15:10:20 +0200 32)
if (commit->date < cutoff)
But it is never too late to fix it. :)
-Peff
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-11-13 4:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1352568970-4669-1-git-send-email-jeanjacques.lafay@gmail.com>
2012-11-10 20:00 ` [PATCH] git tag --contains : avoid stack overflow Philip Oakley
2012-11-10 21:13 ` Jean-Jacques Lafay
2012-11-10 21:33 ` Pat Thoyts
2012-11-11 16:46 ` René Scharfe
2012-11-11 16:54 ` Jeff King
2012-11-11 23:10 ` Johannes Schindelin
2012-11-12 22:27 ` Jean-Jacques Lafay
2012-11-12 23:14 ` Jeff King
2012-11-13 1:16 ` Johannes Schindelin
2012-11-13 3:46 ` [msysGit] " Jeff King
2012-11-13 4:01 ` Johannes Schindelin
2012-11-13 4:05 ` Jeff King [this message]
2012-11-13 4:52 ` Johannes Schindelin
2012-11-13 4:51 ` Junio C Hamano
2012-11-13 6:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113040541.GA9439@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jeanjacques.lafay@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=philipoakley@iee.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).