From: Kacper Kornet <draenog@pld-linux.org>
To: Chris Rorvick <chris@rorvick.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Angelo Borsotti <angelo.borsotti@gmail.com>,
Drew Northup <n1xim.email@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Philip Oakley <philipoakley@iee.org>,
Johannes Sixt <j6t@kdbg.org>, Jeff King <peff@peff.net>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH v3 0/5] push: update remote tags only with force
Date: Wed, 14 Nov 2012 09:19:21 +0100 [thread overview]
Message-ID: <20121114081921.GA20876@camk.edu.pl> (raw)
In-Reply-To: <CAEUsAPZtF-L5J_g1L5d44BKveoAnJ81PatX94fFS4FM=iW33KA@mail.gmail.com>
On Wed, Nov 14, 2012 at 12:29:14AM -0600, Chris Rorvick wrote:
> >> 2. Require force when updating tag references, even on a fast-forward.
> >> push: flag updates
> >> push: flag updates that require force
> >> push: update remote tags only with force
> >> An email thread initiated by Angelo Borsotti did not come to a
> >> consensus on how push should behave with regard to tag references.
> > I think the original motivation of allowing fast-forward updates to
> > tags was for people who wanted to have "today's recommended version"
> > tag that can float from day to day. I tend to think that was a
> > misguided notion and it is better implemented with a tip of a
> > branch (iow, I personally am OK with the change to forbid tag
> > updates altogether, without --force).
> >> I think a key point is that you currently cannot be sure your push
> >> will not clobber a tag (lightweight or not) in the remote.
> > "Do not update, only add new" may be a good feature, but at the same
> > time I have this suspicion that its usefulness may not necessarily
> > be limited to refs/tags/* hierarchy.
> > I dunno.
> Are you suggesting allowing forwards for just refs/heads/*? I
> initially went this route based on some feedback in the original
> thread, but being that specific broke a couple tests in t5516 (i.e.,
> pushing to refs/remotes/origin/master and another into refs/tmp/*.)
> My initial thought was that I'd broken something and I need to modify
> the patch, but now I think I should just modify those tests. Branches
> are restricted to refs/heads/* (if I understand correctly), so
> allowing fast-forwards when pushing should be limited to this
> hierarchy, too.
What about notes? I think they should be treated in the same way as
branches. My impression is that tags are exceptional in this respect.
--
Kacper
next prev parent reply other threads:[~2012-11-14 8:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 4:08 [PATCH v3 0/5] push: update remote tags only with force Chris Rorvick
2012-11-12 4:08 ` [PATCH v3 1/5] push: return reject reasons via a mask Chris Rorvick
2012-11-12 4:08 ` [PATCH v3 2/5] push: add advice for rejected tag reference Chris Rorvick
2012-11-12 4:08 ` [PATCH v3 3/5] push: flag updates Chris Rorvick
2012-11-12 4:08 ` [PATCH v3 4/5] push: flag updates that require force Chris Rorvick
2012-11-12 4:08 ` [PATCH v3 5/5] push: update remote tags only with force Chris Rorvick
2012-11-13 21:20 ` [PATCH v3 0/5] " Junio C Hamano
[not found] ` <CAEUsAPYvrR6WsVWCvwoEWA21gzL6Sib0sTyx-c_2tH=8ni69yQ@mail.gmail.com>
2012-11-14 6:29 ` Chris Rorvick
2012-11-14 8:19 ` Kacper Kornet [this message]
2012-11-14 13:22 ` Junio C Hamano
2012-11-14 14:58 ` Angelo Borsotti
2012-11-14 17:32 ` Junio C Hamano
2012-11-14 23:43 ` Angelo Borsotti
2012-11-15 0:09 ` Junio C Hamano
2012-11-15 7:48 ` Angelo Borsotti
2012-11-15 16:50 ` Junio C Hamano
2012-11-13 23:58 ` Drew Northup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114081921.GA20876@camk.edu.pl \
--to=draenog@pld-linux.org \
--cc=angelo.borsotti@gmail.com \
--cc=chris@rorvick.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=n1xim.email@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).