From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Mazur Subject: Re: Failure to extra stable@vger.kernel.org addresses Date: Tue, 20 Nov 2012 22:21:26 +0100 Message-ID: <20121120212126.GA12656@shrek.podlesie.net> References: <20121119151845.GA29678@shrek.podlesie.net> <7vk3thxuj2.fsf@alter.siamese.dyndns.org> <20121119225838.GA23412@shrek.podlesie.net> <7vlidxuowf.fsf@alter.siamese.dyndns.org> <20121120073100.GB7206@shrek.podlesie.net> <20121120075628.GA7159@shrek.podlesie.net> <20121120115942.GA6132@shrek.podlesie.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Felipe Contreras , Junio C Hamano , Felipe Balbi , git@vger.kernel.org, Tomi Valkeinen To: Andreas Schwab X-From: git-owner@vger.kernel.org Tue Nov 20 22:21:44 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TavGJ-0005EQ-M4 for gcvg-git-2@plane.gmane.org; Tue, 20 Nov 2012 22:21:44 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250Ab2KTVV3 (ORCPT ); Tue, 20 Nov 2012 16:21:29 -0500 Received: from [93.179.225.50] ([93.179.225.50]:54257 "EHLO shrek.podlesie.net" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753160Ab2KTVV2 (ORCPT ); Tue, 20 Nov 2012 16:21:28 -0500 Received: by shrek.podlesie.net (Postfix, from userid 603) id 7173262B; Tue, 20 Nov 2012 22:21:26 +0100 (CET) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Nov 20, 2012 at 08:58:20PM +0100, Andreas Schwab wrote: > How about "s/(.*?<[^>]*>).*$/$1/"? That will still fail on "" > , but you'll need a full rfc822 parser to handle the general > case anyway. That will fail also on "" . I think it's good compromise between complexity and correctness. Felipe, may you check, it again? This time the change is trivial. Andreas, may I add you in Thanks-to? Thanks, Krzysiek -- >8 -- Subject: [PATCH] git-send-email: remove garbage after email address In some cases it's very useful to add some additional information after email in Cc-list, for instance: "Cc: Stable kernel #v3.4 v3.5 v3.6" Currently the git refuses to add such invalid email to Cc-list, when the Email::Valid perl module is available or just uses whole line as the email address. Now in sanitize_address() everything after the email address is removed, so the resulting line is correct email address and Email::Valid validates it correctly. To avoid unnecessary complexity this code assumes that in phrase before email address '' never exists. Signed-off-by: Krzysztof Mazur --- git-send-email.perl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/git-send-email.perl b/git-send-email.perl index 5a7c29d..157eabc 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -924,6 +924,10 @@ sub quote_subject { # use the simplest quoting being able to handle the recipient sub sanitize_address { my ($recipient) = @_; + + # remove garbage after email address + $recipient =~ s/(.*?<[^>]*>).*$/$1/; + my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/); if (not $recipient_name) { -- 1.8.0.283.gc57d856