* [PATCH] DESTDIR support in contrib/subtree/Makefile
@ 2012-11-29 15:41 Adam Tkac
2013-01-01 2:58 ` greened
0 siblings, 1 reply; 2+ messages in thread
From: Adam Tkac @ 2012-11-29 15:41 UTC (permalink / raw)
To: git
Signed-off-by: Adam Tkac <atkac@redhat.com>
---
It is a good habit in Makefiles to honor DESTDIR variable to support
`make DESTDIR=/instalroot install`
syntax.
Comments are welcomed.
Regards, Adam
contrib/subtree/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
index 05cdd5c..36ae3e4 100644
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -30,12 +30,12 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)
doc: $(GIT_SUBTREE_DOC)
install: $(GIT_SUBTREE)
- $(INSTALL) -m 755 $(GIT_SUBTREE) $(libexecdir)
+ $(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)
install-doc: install-man
install-man: $(GIT_SUBTREE_DOC)
- $(INSTALL) -m 644 $^ $(man1dir)
+ $(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)
$(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)
xmlto -m $(MANPAGE_NORMAL_XSL) man $^
--
1.8.0
--
Adam Tkac, Red Hat, Inc.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DESTDIR support in contrib/subtree/Makefile
2012-11-29 15:41 [PATCH] DESTDIR support in contrib/subtree/Makefile Adam Tkac
@ 2013-01-01 2:58 ` greened
0 siblings, 0 replies; 2+ messages in thread
From: greened @ 2013-01-01 2:58 UTC (permalink / raw)
To: Adam Tkac; +Cc: git
Adam Tkac <atkac@redhat.com> writes:
> Signed-off-by: Adam Tkac <atkac@redhat.com>
> ---
>
> It is a good habit in Makefiles to honor DESTDIR variable to support
>
> `make DESTDIR=/instalroot install`
>
> syntax.
>
> Comments are welcomed.
Applied. I'll be sending this to the mailing list tonight or tomorrow.
-David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-01 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-29 15:41 [PATCH] DESTDIR support in contrib/subtree/Makefile Adam Tkac
2013-01-01 2:58 ` greened
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).