From: Jeff King <peff@peff.net>
To: Phil Hord <phil.hord@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Shawn Pearce <spearce@spearce.org>,
Felipe Contreras <felipe.contreras@gmail.com>,
Eric Raymond <esr@thyrsus.com>, git <git@vger.kernel.org>
Subject: Re: Millisecond precision in timestamps?
Date: Thu, 29 Nov 2012 15:01:43 -0500 [thread overview]
Message-ID: <20121129200143.GB22084@sigill.intra.peff.net> (raw)
In-Reply-To: <CABURp0pnGYykud1xDn5T+eszQGTrzKLTp6J_O7ZrWwVd-zKpkg@mail.gmail.com>
On Thu, Nov 29, 2012 at 02:14:40PM -0500, Phil Hord wrote:
> > And if we were to add "committer-timestamp" and friends to support
> > negative timestamps anyway (because older tools will not support
> > them), supporting sub-second part might be something we want to
> > think about at the same time.
>
> Posix-time is signed, but I suppose the git tools do not expect/allow
> a '-' character in the stream. Has git considered the year-2038
> problem?
Yes. The timestamp is in base-10 ASCII, so there is no Y2038 problem in
the data format (it is up to the implementation to read it into a
sufficiently large time_t internally, of course[1]).
But negative timestamps are a different story. We use "unsigned long"
internally for timestamps, and fsck will complain about it.
-Peff
[1] We use "unsigned long", which means we are Y2038-fine on I32/LP64
systems, but not on 32-bit or IL32/LLP64 systems. I do not use
Windows, but my understanding is that LLP64 is the norm there, so it
would eventually be a problem. But since we are unsigned, it is
actually a Y2106 problem.
next prev parent reply other threads:[~2012-11-29 20:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 20:48 Millisecond precision in timestamps? Eric S. Raymond
2012-11-27 21:41 ` Shawn Pearce
2012-11-27 22:06 ` Junio C Hamano
2012-11-27 23:04 ` Eric S. Raymond
2012-11-27 23:49 ` Shawn Pearce
2012-11-28 0:12 ` Eric S. Raymond
2012-11-28 0:22 ` David Lang
2012-11-28 0:26 ` Felipe Contreras
2012-11-28 1:07 ` Shawn Pearce
2012-11-28 1:17 ` Jeff King
2012-11-28 1:29 ` Jason Pyeron
2012-11-28 1:42 ` Felipe Contreras
2012-11-28 3:23 ` Eric S. Raymond
2012-11-28 3:30 ` Jeff King
2012-11-28 3:44 ` Felipe Contreras
2012-11-28 3:47 ` Eric S. Raymond
2012-11-28 4:07 ` Jeff King
2012-11-28 4:25 ` Eric S. Raymond
2012-11-28 7:29 ` Junio C Hamano
2012-11-28 7:58 ` Eric S. Raymond
2012-11-28 8:04 ` David Aguilar
2012-11-28 10:14 ` Andreas Ericsson
2012-12-05 23:37 ` Robin Rosenberg
2012-12-10 20:56 ` James Cloos
2012-11-28 8:19 ` Thomas Berg
2012-11-28 8:44 ` Felipe Contreras
2012-11-28 9:10 ` Thomas Berg
[not found] ` <E4C993F4-B7A4-4CB6-A9EA-BFE98BE3A381@gmail.com>
2012-11-29 6:16 ` Eric S. Raymond
2012-11-29 7:11 ` Junio C Hamano
2012-11-29 7:22 ` Felipe Contreras
2012-11-29 10:38 ` Eric S. Raymond
2012-11-29 16:42 ` Junio C Hamano
2012-11-29 19:02 ` Eric S. Raymond
2012-11-28 17:57 ` Junio C Hamano
2012-11-28 10:10 ` Andreas Ericsson
2012-11-29 19:14 ` Phil Hord
2012-11-29 20:01 ` Jeff King [this message]
2012-11-28 1:11 ` Eric S. Raymond
2012-11-28 1:36 ` Felipe Contreras
2012-11-28 2:01 ` Junio C Hamano
2012-11-27 21:44 ` Pyeron, Jason J CTR (US)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129200143.GB22084@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=esr@thyrsus.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phil.hord@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).