From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH/RFC 0/5] win32: support echo for terminal-prompt
Date: Fri, 30 Nov 2012 13:30:16 -0500 [thread overview]
Message-ID: <20121130183016.GF7197@sigill.intra.peff.net> (raw)
In-Reply-To: <CABPQNSZ7YRgvS1=SR=Nx0wcn+NXCVwqjVShk-ug3=yX62RH-oQ@mail.gmail.com>
On Fri, Nov 30, 2012 at 11:16:59AM +0100, Erik Faye-Lund wrote:
> Ping?
Thanks for the reminder; your initial series came while I was traveling.
I think it looks good. The compat/terminal code ends up a little uglier,
but I think you overall did a good job of balancing code reuse across
platforms with readability.
-Peff
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
prev parent reply other threads:[~2012-11-30 18:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 14:04 [PATCH/RFC 0/5] win32: support echo for terminal-prompt Erik Faye-Lund
2012-11-13 14:04 ` [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate Erik Faye-Lund
2012-11-30 17:58 ` Johannes Schindelin
2012-11-30 18:11 ` [msysGit] " Jeff King
2012-12-01 12:31 ` Erik Faye-Lund
2012-12-01 17:39 ` Jeff King
2012-12-01 12:36 ` Erik Faye-Lund
2012-12-04 17:12 ` Johannes Schindelin
2012-12-04 17:40 ` Erik Faye-Lund
2012-12-02 10:42 ` Junio C Hamano
2012-12-03 23:29 ` Erik Faye-Lund
2012-12-04 0:23 ` Junio C Hamano
2012-11-13 14:04 ` [PATCH/RFC 2/5] compat/terminal: factor out echo-disabling Erik Faye-Lund
2012-11-30 17:59 ` Johannes Schindelin
2012-11-30 18:19 ` Jeff King
2012-12-01 12:43 ` Erik Faye-Lund
2012-12-04 17:12 ` Johannes Schindelin
2012-11-13 14:04 ` [PATCH/RFC 3/5] compat/terminal: separate input and output handles Erik Faye-Lund
2012-11-30 18:22 ` Jeff King
2012-11-13 14:04 ` [PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt Erik Faye-Lund
2012-11-30 18:05 ` Johannes Schindelin
2012-11-30 18:27 ` Jeff King
2012-11-13 14:04 ` [PATCH/RFC 5/5] mingw: get rid of getpass implementation Erik Faye-Lund
2012-11-30 18:06 ` Johannes Schindelin
2012-11-30 18:27 ` Jeff King
2012-11-30 10:16 ` [PATCH/RFC 0/5] win32: support echo for terminal-prompt Erik Faye-Lund
2012-11-30 18:30 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130183016.GF7197@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).