From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>, git@vger.kernel.org
Subject: Re: [PATCH] status: respect advice.statusHints for ahead/behind advice
Date: Mon, 3 Dec 2012 13:32:43 -0500 [thread overview]
Message-ID: <20121203183243.GA25526@sigill.intra.peff.net> (raw)
In-Reply-To: <7vr4n7rrgb.fsf@alter.siamese.dyndns.org>
On Mon, Dec 03, 2012 at 09:11:32AM -0800, Junio C Hamano wrote:
> > On top of mm/status-push-pull-advise.
> >
> > I left "git checkout" alone, though I'd also like to turn it off there,
> > too. Should it get a separate advice option there? Should it simply
> > respect statusHints (it seems odd because I know that "status" there
> > means "git status", not "hints about the status of your repo")?
>
> I agree that we should have a toggle to turn it off and I think it
> is OK to reuse the same "hints about the status" option for this
> purpose. It is not like there is a released version that already
> gives the advice (possibly with some other option to turn it off)
> and you are changing the behaviour of "checkout" by suddenly making
> it honor statusHints advice.
>
> So let's do a lot simpler patch instead.
>
> -- >8 --
Perfect, thanks.
-Peff
next prev parent reply other threads:[~2012-12-03 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 6:16 [PATCH] status: respect advice.statusHints for ahead/behind advice Jeff King
2012-12-03 8:49 ` Matthieu Moy
2012-12-03 17:11 ` Junio C Hamano
2012-12-03 18:32 ` Jeff King [this message]
2012-12-04 9:17 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203183243.GA25526@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).