From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Łukasz Stelmach" <stlman@poczta.fm>,
git@vger.kernel.org, mbranchaud@xiplink.com
Subject: Re: [PATCH] gitk: read and write a repository specific configuration file
Date: Sun, 9 Dec 2012 21:44:26 +1100 [thread overview]
Message-ID: <20121209104426.GA20818@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <7vd2yjeg8f.fsf@alter.siamese.dyndns.org>
On Sun, Dec 09, 2012 at 01:18:08AM -0800, Junio C Hamano wrote:
> Łukasz Stelmach <stlman@poczta.fm> writes:
>
> > Enable gitk read and write repository specific configuration
> > file: ".git/k" if the file exists. To make gitk use the local
> > file simply create one, e.g. with the touch(1) command.
> >
> > This is very useful if one uses different views for different
> > repositories. Now there is no need to store all of them in
> > ~/.gitk and make the views list needlessly long.
>
> I do not use gitk heavily myself, but I have a mixed feeling about
> this patch.
I agree, I think this would be surprising to people who are used to
the way gitk works now.
I could imagine having a checkbox in the Edit->Preferences dialog to
say "Save configuration settings locally", and if you check that box,
then it writes the configuration to .git/gitkconfig or whatever
(having first saved that setting in the global ~/.gitk). But I think
it should be an opt-in thing.
> In any case, the filename .git/k may be _cute_, but I do not think
> we would want to see:
>
> $ ls .git
> branches config HEAD index k objects
> COMMIT_EDITMSG description hooks info logs refs
>
> It is too cryptic, unless the user _knows_ 'k' is for gitk. I'd
> call it $GIT_DIR/gitkconfig or something, if I were supportive for
> this feature (which I am not enthusiastic, yet).
I agree with this too.
Paul.
next prev parent reply other threads:[~2012-12-09 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 21:08 [PATCH] gitk: add a checkbox to control the visibility of tags Łukasz Stelmach
2012-12-02 2:16 ` Junio C Hamano
2012-12-02 21:25 ` Lukasz Stelmach
2012-12-02 21:29 ` [PATCH] gitk: read and write a repository specific configuration file Łukasz Stelmach
2012-12-03 21:15 ` Stefan Haller
2012-12-04 20:12 ` Lukasz Stelmach
2012-12-05 0:49 ` [PATCH v2] " Łukasz Stelmach
2012-12-05 15:20 ` Marc Branchaud
2012-12-08 11:27 ` [PATCH] " Łukasz Stelmach
2012-12-09 9:18 ` Junio C Hamano
2012-12-09 10:44 ` Paul Mackerras [this message]
2012-12-09 13:25 ` Lukasz Stelmach
2012-12-09 13:13 ` Lukasz Stelmach
2012-12-02 21:40 ` [PATCH] gitk: add a checkbox to control the visibility of tags Felipe Contreras
2013-01-02 7:17 ` Paul Mackerras
2013-01-02 7:24 ` Junio C Hamano
2013-01-02 8:03 ` Lukasz Stelmach
2013-01-02 17:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209104426.GA20818@bloggs.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mbranchaud@xiplink.com \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).