From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t0200: "locale" may not exist
Date: Wed, 19 Dec 2012 10:32:05 -0500 [thread overview]
Message-ID: <20121219153205.GA22207@sigill.intra.peff.net> (raw)
In-Reply-To: <7vd2y6awo7.fsf@alter.siamese.dyndns.org>
On Wed, Dec 19, 2012 at 07:28:24AM -0800, Junio C Hamano wrote:
> > +test_expect_success GETTEXT,!GETTEXT_POISON 'setup locale' '
> > # is_IS.UTF-8 on Solaris and FreeBSD, is_IS.utf8 on Debian
> > - is_IS_locale=$(locale -a | sed -n '/^is_IS\.[uU][tT][fF]-*8$/{
> > + is_IS_locale=$(locale -a | sed -n "/^is_IS\.[uU][tT][fF]-*8\$/{
>
> Do we need to do this \$?
I'm not sure. Sane shells leave "$/" untouched, but I do not know if we
need to be conservative.
> > - say "# lib-gettext: Found '$is_IS_locale' as an is_IS UTF-8 locale"
> > + say "# lib-gettext: Found \"$is_IS_locale\" as an is_IS UTF-8 locale"
>
> '\''?
Fine by me. I do not care either way in the output, and the escaped dq
is marginally more readable in the source. But either way the source is
pretty ugly. :)
-Peff
prev parent reply other threads:[~2012-12-19 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 6:47 [PATCH] t0200: "locale" may not exist Junio C Hamano
2012-12-19 13:18 ` Jeff King
2012-12-19 15:28 ` Junio C Hamano
2012-12-19 15:32 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219153205.GA22207@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).