From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)
Date: Thu, 20 Dec 2012 09:59:41 -0500 [thread overview]
Message-ID: <20121220145941.GC27211@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4njjf6fk.fsf@alter.siamese.dyndns.org>
On Tue, Dec 18, 2012 at 12:31:43PM -0800, Junio C Hamano wrote:
> * jk/error-const-return (2012-12-15) 2 commits
> - silence some -Wuninitialized false positives
> - make error()'s constant return value more visible
>
> Help compilers' flow analysis by making it more explicit that
> error() always returns -1, to reduce false "variable used
> uninitialized" warnings.
>
> This is still an RFC.
What's your opinion on this? The last round I posted (and what you have
in pu) is about as good as this technique is going to get. So it is
really a taste thing. On the one hand, I really like that it is not just
papering over the problem, but rather giving the compiler more data to
do its analysis. On the other hand, it makes the source kind of ugly.
I don't think there's a rush on it, but I'm just sifting through my
half-done topics.
-Peff
next prev parent reply other threads:[~2012-12-20 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 20:31 What's cooking in git.git (Dec 2012, #05; Tue, 18) Junio C Hamano
2012-12-19 20:47 ` Junio C Hamano
2012-12-20 14:59 ` Jeff King [this message]
2012-12-20 18:13 ` Junio C Hamano
2012-12-20 19:58 ` Jeff King
2012-12-20 20:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220145941.GC27211@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).