From: "Eric S. Raymond" <esr@thyrsus.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Python scripts audited for minimum compatible version and checks added.
Date: Thu, 20 Dec 2012 10:02:52 -0500 [thread overview]
Message-ID: <20121220150252.GA24387@thyrsus.com> (raw)
In-Reply-To: <20121220144813.GA27211@sigill.intra.peff.net>
Jeff King <peff@peff.net>:
> On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote:
>
> > diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py
> > index bd24395..b55648f 100755
> > --- a/contrib/ciabot/ciabot.py
> > +++ b/contrib/ciabot/ciabot.py
> > @@ -50,6 +50,11 @@
> > import os, sys, commands, socket, urllib
> > from xml.sax.saxutils import escape
> >
> > +if sys.hexversion < 0x02000000:
> > + # The limiter is the xml.sax module
> > + sys.stderr.write("import-zips.py: requires Python 2.0.0 or later.")
> > + sys.exit(1)
>
> Should the error message say ciabot.py?
>
> -Peff
Gack. Yes. Thaty's what I get for cut-and-pasting too quickly.
The information about xnml.sex is correct, though.
Want me to resubmit, or will you just patch it?
Note by the way that I still think the entire ciabot subtree (which is
my code) should just be nuked. CIA is not coming back, wishful thinking
on Ilkotech's web page notwithstanding.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2012-12-20 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 14:13 [PATCH] Python scripts audited for minimum compatible version and checks added Eric S. Raymond
2012-12-20 14:48 ` Jeff King
2012-12-20 15:02 ` Eric S. Raymond [this message]
2012-12-20 18:25 ` Junio C Hamano
2012-12-21 3:38 ` Junio C Hamano
2012-12-24 4:57 ` Junio C Hamano
2012-12-24 5:21 ` Eric S. Raymond
2012-12-21 15:58 ` Manlio Perillo
2012-12-24 13:36 ` Pete Wyckoff
2012-12-24 15:32 ` Eric S. Raymond
2012-12-24 19:12 ` Junio C Hamano
2012-12-24 19:52 ` Eric S. Raymond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220150252.GA24387@thyrsus.com \
--to=esr@thyrsus.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).