From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Adam Spiers <git@adamspiers.org>, git mailing list <git@vger.kernel.org>
Subject: Re: $PATH pollution and t9902-completion.sh
Date: Thu, 20 Dec 2012 15:01:09 -0500 [thread overview]
Message-ID: <20121220200109.GC21785@sigill.intra.peff.net> (raw)
In-Reply-To: <7vobho4hxa.fsf@alter.siamese.dyndns.org>
On Thu, Dec 20, 2012 at 11:55:45AM -0800, Junio C Hamano wrote:
> The beginning of such a change may look like the attached patch.
> [...]
> +test_fully_contains () {
> + sort "$1" >expect.sorted &&
> + sort "$2" >actual.sorted &&
> + test $(comm -23 expect.sorted actual.sorted | wc -l) = 0
> +}
I like the direction. I suspect test_fully_contains could be used in a
lot of other places, too.
-Peff
next prev parent reply other threads:[~2012-12-20 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 1:05 $PATH pollution and t9902-completion.sh Adam Spiers
2012-12-20 14:55 ` Jeff King
2012-12-20 15:13 ` Adam Spiers
2012-12-20 17:25 ` Torsten Bögershausen
2012-12-20 18:36 ` Junio C Hamano
2012-12-20 19:55 ` Junio C Hamano
2012-12-20 20:01 ` Jeff King [this message]
2012-12-20 20:53 ` Torsten Bögershausen
2012-12-20 21:02 ` Junio C Hamano
2012-12-20 21:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220200109.GC21785@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).