From: Jeff King <peff@peff.net>
To: Rene Bredlau <git@unrelated.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] http.c: Avoid username prompt for certifcate credentials
Date: Fri, 21 Dec 2012 12:09:27 -0500 [thread overview]
Message-ID: <20121221170927.GA23574@sigill.intra.peff.net> (raw)
In-Reply-To: <1356107479-6668-1-git-send-email-git@unrelated.de>
On Fri, Dec 21, 2012 at 05:31:19PM +0100, Rene Bredlau wrote:
> If sslCertPasswordProtected is set to true do not ask for username to
> decrypt rsa key. This question is pointless, the key is only protected
> by a password. Internaly the username is simply set to "".
Yeah, that makes sense. I suspect the cert-unlocking code paths for
credential helpers are not that well used (and I do not think we have
any test coverage for them at all), so I am not too surprised that this
went unreported for a long time.
Thanks.
> Signed-off-by: Rene Bredlau <git@unrelated.de>
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2012-12-21 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 16:31 [PATCH] http.c: Avoid username prompt for certifcate credentials Rene Bredlau
2012-12-21 17:09 ` Jeff King [this message]
2012-12-21 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121221170927.GA23574@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@unrelated.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox