* Bug in latest gitk - can't click lines connecting commits
@ 2013-01-01 17:21 Jason Holden
2013-01-01 17:54 ` Stefan Haller
0 siblings, 1 reply; 6+ messages in thread
From: Jason Holden @ 2013-01-01 17:21 UTC (permalink / raw)
To: git; +Cc: paulus, stefan
I was testing some patches against the latest gitk, and noticed that when I
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
Error: can't read "cflist_top": no such variable
Looks like this was introduced in gitk commit b967135d89e8d8461d059
gitk: Synchronize highlighting in file view when scrolling diff
This commit hasn't been merged yet from upstream into git.
Here's the full error trace:
can't read "cflist_top": no such variable
can't read "cflist_top": no such variable
while executing
"$cflist tag remove highlight $cflist_top.0 "$cflist_top.0 lineend""
(procedure "highlightfile" line 4)
invoked from within
"highlightfile 0"
(procedure "highlightfile_for_scrollpos" line 8)
invoked from within
"highlightfile_for_scrollpos $topidx"
(procedure "scrolltext" line 9)
invoked from within
"scrolltext 0.0 1.0"
(vertical scrolling command executed by text)
-Jason
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Bug in latest gitk - can't click lines connecting commits
2013-01-01 17:21 Bug in latest gitk - can't click lines connecting commits Jason Holden
@ 2013-01-01 17:54 ` Stefan Haller
2013-01-01 23:22 ` Paul Mackerras
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Haller @ 2013-01-01 17:54 UTC (permalink / raw)
To: Jason Holden, git; +Cc: paulus
Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
> I was testing some patches against the latest gitk, and noticed that when I
> click the mouse on the lines that connect the commits in the history graph,
> I get an error popup with:
> Error: can't read "cflist_top": no such variable
>
> Looks like this was introduced in gitk commit b967135d89e8d8461d059
> gitk: Synchronize highlighting in file view when scrolling diff
A patch that fixes this was proposed over two months ago, and Paul said
he had applied it:
<http://permalink.gmane.org/gmane.comp.version-control.git/208162>
However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
Paul?
--
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in latest gitk - can't click lines connecting commits
2013-01-01 17:54 ` Stefan Haller
@ 2013-01-01 23:22 ` Paul Mackerras
2013-01-22 17:28 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Paul Mackerras @ 2013-01-01 23:22 UTC (permalink / raw)
To: Stefan Haller; +Cc: Jason Holden, git
On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
> Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
>
> > I was testing some patches against the latest gitk, and noticed that when I
> > click the mouse on the lines that connect the commits in the history graph,
> > I get an error popup with:
> > Error: can't read "cflist_top": no such variable
> >
> > Looks like this was introduced in gitk commit b967135d89e8d8461d059
> > gitk: Synchronize highlighting in file view when scrolling diff
>
> A patch that fixes this was proposed over two months ago, and Paul said
> he had applied it:
>
> <http://permalink.gmane.org/gmane.comp.version-control.git/208162>
>
> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
> Paul?
I just forgot to push it out. It's there now.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in latest gitk - can't click lines connecting commits
2013-01-01 23:22 ` Paul Mackerras
@ 2013-01-22 17:28 ` Junio C Hamano
2013-01-23 11:48 ` Paul Mackerras
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2013-01-22 17:28 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Stefan Haller, Jason Holden, git
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
>> Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
>>
>> > I was testing some patches against the latest gitk, and noticed that when I
>> > click the mouse on the lines that connect the commits in the history graph,
>> > I get an error popup with:
>> > Error: can't read "cflist_top": no such variable
>> >
>> > Looks like this was introduced in gitk commit b967135d89e8d8461d059
>> > gitk: Synchronize highlighting in file view when scrolling diff
>>
>> A patch that fixes this was proposed over two months ago, and Paul said
>> he had applied it:
>>
>> <http://permalink.gmane.org/gmane.comp.version-control.git/208162>
>>
>> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
>> Paul?
>
> I just forgot to push it out. It's there now.
I notice that I have a handful of commits that I haven't pulled from
your repository, and the last commit on your 'master' is about 20
days old. Is it safe for me to pull these now?
I can teach myself that your push is your pull-request, but I do not
think we agreed to arrange it that way yet, so...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in latest gitk - can't click lines connecting commits
2013-01-22 17:28 ` Junio C Hamano
@ 2013-01-23 11:48 ` Paul Mackerras
2013-01-23 16:35 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Paul Mackerras @ 2013-01-23 11:48 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:
>
> I notice that I have a handful of commits that I haven't pulled from
> your repository, and the last commit on your 'master' is about 20
> days old. Is it safe for me to pull these now?
Yes, please pull them now.
Regards,
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in latest gitk - can't click lines connecting commits
2013-01-23 11:48 ` Paul Mackerras
@ 2013-01-23 16:35 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2013-01-23 16:35 UTC (permalink / raw)
To: Paul Mackerras; +Cc: git
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:
>>
>> I notice that I have a handful of commits that I haven't pulled from
>> your repository, and the last commit on your 'master' is about 20
>> days old. Is it safe for me to pull these now?
>
> Yes, please pull them now.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-23 16:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-01 17:21 Bug in latest gitk - can't click lines connecting commits Jason Holden
2013-01-01 17:54 ` Stefan Haller
2013-01-01 23:22 ` Paul Mackerras
2013-01-22 17:28 ` Junio C Hamano
2013-01-23 11:48 ` Paul Mackerras
2013-01-23 16:35 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).