* [PATCH 3/4] t4014: do not uese echo -n
@ 2013-01-01 21:41 Torsten Bögershausen
2013-01-02 1:16 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Torsten Bögershausen @ 2013-01-01 21:41 UTC (permalink / raw)
To: git; +Cc: tboegi
echo -n is not portable on all systems.
Use printf instead
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
t/t4014-format-patch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 6cfad13..f460930 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -993,7 +993,7 @@ EOF
'
test_expect_success 'signoff: commit with only subject that does not end with NL' '
- echo -n subject | append_signoff >actual &&
+ printf subject | append_signoff >actual &&
cat >expected <<\EOF &&
4:Subject: [PATCH] subject
8:
--
1.8.0.197.g5a90748
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] t4014: do not uese echo -n
2013-01-01 21:41 [PATCH 3/4] t4014: do not uese echo -n Torsten Bögershausen
@ 2013-01-02 1:16 ` Junio C Hamano
2013-01-02 8:42 ` Brandon Casey
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2013-01-02 1:16 UTC (permalink / raw)
To: Brandon Casey; +Cc: git, Torsten Bögershausen
Torsten Bögershausen <tboegi@web.de> writes:
> echo -n is not portable on all systems.
> Use printf instead
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
Brandon, this comes from 932581b (Unify appending signoff in
format-patch, commit and sequencer, 2012-11-25). Please make sure
to squash it in when you reroll the series.
Thanks (and a happy new year ;-).
> t/t4014-format-patch.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 6cfad13..f460930 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -993,7 +993,7 @@ EOF
> '
>
> test_expect_success 'signoff: commit with only subject that does not end with NL' '
> - echo -n subject | append_signoff >actual &&
> + printf subject | append_signoff >actual &&
> cat >expected <<\EOF &&
> 4:Subject: [PATCH] subject
> 8:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] t4014: do not uese echo -n
2013-01-02 1:16 ` Junio C Hamano
@ 2013-01-02 8:42 ` Brandon Casey
0 siblings, 0 replies; 3+ messages in thread
From: Brandon Casey @ 2013-01-02 8:42 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Torsten Bögershausen
On Tue, Jan 1, 2013 at 5:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> echo -n is not portable on all systems.
>> Use printf instead
>>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>
> Brandon, this comes from 932581b (Unify appending signoff in
> format-patch, commit and sequencer, 2012-11-25). Please make sure
> to squash it in when you reroll the series.
Will do.
> Thanks (and a happy new year ;-).
Thanks. Happy New Year to you too. :)
-Brandon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-02 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-01 21:41 [PATCH 3/4] t4014: do not uese echo -n Torsten Bögershausen
2013-01-02 1:16 ` Junio C Hamano
2013-01-02 8:42 ` Brandon Casey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).