From: Paul Mackerras <paulus@samba.org>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: Jason Holden <jason.k.holden.swdev@gmail.com>, git@vger.kernel.org
Subject: Re: Bug in latest gitk - can't click lines connecting commits
Date: Wed, 2 Jan 2013 10:22:20 +1100 [thread overview]
Message-ID: <20130101232220.GD20724@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1kw18d3.5sftkl125qdz4M%stefan@haller-berlin.de>
On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
> Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
>
> > I was testing some patches against the latest gitk, and noticed that when I
> > click the mouse on the lines that connect the commits in the history graph,
> > I get an error popup with:
> > Error: can't read "cflist_top": no such variable
> >
> > Looks like this was introduced in gitk commit b967135d89e8d8461d059
> > gitk: Synchronize highlighting in file view when scrolling diff
>
> A patch that fixes this was proposed over two months ago, and Paul said
> he had applied it:
>
> <http://permalink.gmane.org/gmane.comp.version-control.git/208162>
>
> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
> Paul?
I just forgot to push it out. It's there now.
Paul.
next prev parent reply other threads:[~2013-01-02 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 17:21 Bug in latest gitk - can't click lines connecting commits Jason Holden
2013-01-01 17:54 ` Stefan Haller
2013-01-01 23:22 ` Paul Mackerras [this message]
2013-01-22 17:28 ` Junio C Hamano
2013-01-23 11:48 ` Paul Mackerras
2013-01-23 16:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130101232220.GD20724@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=jason.k.holden.swdev@gmail.com \
--cc=stefan@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).