From: Paul Mackerras <paulus@samba.org>
To: Leon KUKOVEC <leon.kukovec@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk tag delete/rename support
Date: Wed, 2 Jan 2013 18:11:53 +1100 [thread overview]
Message-ID: <20130102071153.GF20724@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1353870345-3054-1-git-send-email-leon.kukovec@gmail.com>
On Sun, Nov 25, 2012 at 08:05:45PM +0100, Leon KUKOVEC wrote:
> Right clicking on a tag pops up a menu, which allows
> tag to be renamed or deleted.
Nice idea, but I am concerned that renaming a tag that refers to a tag
object will turn it into a lightweight tag, which would be surprising
for users. I think that needs to be fixed before I apply the patch.
Also, when renaming a tag it would be good to check for the cases
where the new name is the same as the old (in which case nothing needs
to be done) and where the new name already exists.
Thanks,
Paul.
prev parent reply other threads:[~2013-01-02 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:51 [PATCH] gitk tag delete/rename support Leon KUKOVEC
2012-11-23 12:38 ` Ramkumar Ramachandra
2012-11-23 16:41 ` Leon KUKOVEC
2012-11-25 6:26 ` Junio C Hamano
2012-11-25 16:02 ` Leon KUKOVEC
2012-11-25 19:05 ` Leon KUKOVEC
2013-01-02 7:11 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102071153.GF20724@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=leon.kukovec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).