git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Łukasz Stelmach" <stlman@poczta.fm>
Subject: Re: [PATCH] gitk: add a checkbox to control the visibility of tags
Date: Wed, 2 Jan 2013 18:17:01 +1100	[thread overview]
Message-ID: <20130102071701.GG20724@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <7vlidhmc5i.fsf@alter.siamese.dyndns.org>

On Sat, Dec 01, 2012 at 06:16:25PM -0800, Junio C Hamano wrote:
> Łukasz Stelmach <stlman@poczta.fm> writes:
> 
> > Enable hiding of tags displayed in the tree as yellow labels.
> > If a repository is used together with a system like Gerrit
> > there may be quite a lot of tags used to control building
> > and there may be hardly any place left for commit subjects.
> >
> > Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
> > ---
> 
> Paul, this patch is not done against your tree (does not have gitk
> at the top-level), but other than that, the change mimics the way
> existing hideremoes is implemented and looks reasonable to me.
> 
> We _may_ want to unify these two "hidestuff" into a list of patterns
> that hides any ref that match one of the patterns in the list, e.g.
> 
> 	set hidestuff {refs/heads/*/* refs/tags/* refs/remotes/*}
> 
> may hide all tags, all remote-tracking branches and local branches
> that have a slash in their names.

If the concern is the amount of screen real-estate that the tags take
up when there are many of them (which is a reasonable concern), I'd
rather just put a single tag icon with "tags..." inside it and arrange
to list all the tags in the diff display pane when the user clicks on
it.  I think that would be better than not showing the tags at all.

Paul.

  parent reply	other threads:[~2013-01-02  7:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30 21:08 [PATCH] gitk: add a checkbox to control the visibility of tags Łukasz Stelmach
2012-12-02  2:16 ` Junio C Hamano
2012-12-02 21:25   ` Lukasz Stelmach
2012-12-02 21:29     ` [PATCH] gitk: read and write a repository specific configuration file Łukasz Stelmach
2012-12-03 21:15       ` Stefan Haller
2012-12-04 20:12         ` Lukasz Stelmach
2012-12-05  0:49       ` [PATCH v2] " Łukasz Stelmach
2012-12-05 15:20         ` Marc Branchaud
2012-12-08 11:27           ` [PATCH] " Łukasz Stelmach
2012-12-09  9:18             ` Junio C Hamano
2012-12-09 10:44               ` Paul Mackerras
2012-12-09 13:25                 ` Lukasz Stelmach
2012-12-09 13:13               ` Lukasz Stelmach
2012-12-02 21:40   ` [PATCH] gitk: add a checkbox to control the visibility of tags Felipe Contreras
2013-01-02  7:17   ` Paul Mackerras [this message]
2013-01-02  7:24     ` Junio C Hamano
2013-01-02  8:03       ` Lukasz Stelmach
2013-01-02 17:08         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130102071701.GG20724@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stlman@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).