From: Jonathan Nieder <jrnieder@gmail.com>
To: Martin von Zweigbergk <martinvonz@gmail.com>
Cc: Stefano Lattarini <stefano.lattarini@gmail.com>,
Jeff King <peff@peff.net>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed
Date: Wed, 2 Jan 2013 00:42:48 -0800 [thread overview]
Message-ID: <20130102084248.GA22919@elie.Belkin> (raw)
In-Reply-To: <20130102082544.GD18974@elie.Belkin>
Jonathan Nieder wrote:
> Starting with v1.7.12-rc0~4^2 (build: reconfigure automatically if
> configure.ac changes, 2012-07-19), configure is automatically run
> every time the "configure" script changes. In particular, that
> means configure is automatically rerun whenever the version number
> changes (which changes the configure script to support "./configure
> --helpe")
Gah, I sent the log commit message --- the patch description from v1
is the right one. Sorry for the trouble. Here is the fixed
description again.
Subject: build: do not automatically reconfigure unless configure.ac changed
Starting with v1.7.12-rc0~4^2 (build: reconfigure automatically if
configure.ac changes, 2012-07-19), "config.status --recheck" is
automatically run every time the "configure" script changes. In
particular, that means the configuration procedure repeats whenever
the version number changes (since the configure script changes to
support "./configure --version" and "./configure --help"), making
bisecting painfully slow.
The intent was to make the reconfiguration process only trigger for
changes to configure.ac's logic. Tweak the Makefile rule to match
that intent by depending on configure.ac instead of configure.
Reported-by: Martin von Zweigbergk <martinvonz@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2013-01-02 8:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 1:11 Makefile dependency from 'configure' to 'GIT-VERSION-FILE' Martin von Zweigbergk
2013-01-02 7:21 ` Jonathan Nieder
2013-01-02 7:47 ` Martin von Zweigbergk
2013-01-02 8:25 ` [PATCH v2] build: do not automatically reconfigure unless configure.ac changed Jonathan Nieder
2013-01-02 8:38 ` Jeff King
2013-01-02 8:48 ` Jonathan Nieder
2013-01-02 14:13 ` Stefano Lattarini
2013-01-02 16:50 ` Junio C Hamano
2013-01-02 17:07 ` Martin von Zweigbergk
2013-01-02 19:35 ` Stefano Lattarini
2013-01-02 20:25 ` Junio C Hamano
2013-01-02 20:53 ` Stefano Lattarini
2013-01-02 8:42 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102084248.GA22919@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martinvonz@gmail.com \
--cc=peff@peff.net \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).