git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Eric S. Raymond" <esr@thyrsus.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Replace git-cvsimport with a rewrite that fixes major bugs.
Date: Wed, 2 Jan 2013 08:35:58 -0800	[thread overview]
Message-ID: <20130102163527.GA31196@elie.Belkin> (raw)
In-Reply-To: <20130102161848.GA18447@thyrsus.com>

Eric S. Raymond wrote:
> Jonathan Nieder <jrnieder@gmail.com>:

>> The former is already loudly advertised in the package description and
>> manpage, at least lets you get work done, and works fine for simple
>> repositories with linear history.
>
> Two of the three claims in this paragraph are false.

Give me a break.

Are you telling me that when multiple users read a manpage that states

| WARNING: for certain situations the import leads to incorrect
| results. Please see the section ISSUES for further reference.
[...]
| Problems related to timestamps:
[...]
| Problems related to branches:
[...]
| Problems related to tags:
[...]
| consider using these alternative tools which proved to be more
| stable in practice:

and a package description that states

| The git cvsimport tool can incrementally import from a repository
| that is being actively developed and only requires remote access
| over CVS protocol. Unfortunately, in many situations the import
| leads to incorrect results. For reliable, one-shot imports, cvs2git
| from the cvs2svn package or parsecvs may be a better fit.

and decide to use the tool anyway, this is not evidence that the tool
is invaluable to them, despite its shortcomings?

Perhaps the users reporting bugs didn't read the manpage and package
description (despite quoting the same passages and explaining why they
used the command nonetheless) or I should ignore the judgement calls
they make.

Consider the following workflow:

 1. Update imported project periodically using git-cvsimport
 2. Hack, do code archaeology using "git log -S" and "git bisect",
    etc.
 3. Fall back to a web browser and cvsweb to confirm conclusions.

You are telling me that it is not a regression to change the workflow
to the following:

 1. Try to use git-cvsimport.
 2. Wonder where that command went.

Meanwhile Junio has already suggested a way out.  Just rename the
command.

Hope that helps,
Jonathan

  parent reply	other threads:[~2013-01-02 16:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-01 17:26 [PATCH] Replace git-cvsimport with a rewrite that fixes major bugs Eric S. Raymond
2013-01-01 21:54 ` Junio C Hamano
2013-01-02  0:33   ` Eric S. Raymond
2013-01-02  1:06     ` Junio C Hamano
2013-01-02  8:02     ` Jonathan Nieder
2013-01-02 10:59       ` Eric S. Raymond
2013-01-02 15:39         ` Jonathan Nieder
2013-01-02 16:18           ` Eric S. Raymond
2013-01-02 16:32             ` Martin Langhoff
2013-01-02 16:41               ` Eric S. Raymond
2013-01-02 16:48                 ` Thomas Berg
2013-01-02 21:15                 ` Martin Langhoff
2013-01-02 22:28                   ` Eric S. Raymond
2013-01-02 23:44                     ` Martin Langhoff
2013-01-02 16:35             ` Jonathan Nieder [this message]
2013-01-02 16:43             ` Andreas Schwab
2013-01-02 18:08     ` Junio C Hamano
2013-01-02 18:37       ` Eric S. Raymond
2013-01-02 19:07         ` Junio C Hamano
2013-01-03  6:34 ` Chris Rorvick
2013-01-03  7:08   ` Junio C Hamano
2013-01-03  7:47     ` Antoine Pelisse
2013-01-03 15:22       ` Junio C Hamano
2013-01-03 16:24         ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130102163527.GA31196@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=esr@thyrsus.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).