From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Dan McGee <dan@archlinux.org>,
GIT Mailing-list <git@vger.kernel.org>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>,
David Michael Barr <b@rr-dav.id.au>,
"Eric S. Raymond" <esr@thyrsus.com>
Subject: Re: Test failures with python versions when building git 1.8.1
Date: Wed, 2 Jan 2013 15:54:35 -0500 [thread overview]
Message-ID: <20130102205435.GA24810@sigill.intra.peff.net> (raw)
In-Reply-To: <7vip7f4k7x.fsf@alter.siamese.dyndns.org>
On Wed, Jan 02, 2013 at 08:34:42AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Whether we end up doing something with contrib and tests or not, the
> > patch below gives a minimal fix in the meantime.
>
> Replacing the symbolic link with write_script that uses exported
> variables looks like a familiar pattern. I like it.
>
> Oh, wait. That pattern is of course familiar, because 5a02966
> (t9020: use configured Python to run the test helper, 2012-12-18)
> has been in 'next', and is planned for the first batch.
Great minds think alike, I guess?
Would have been nice to mention that you had done a patch when you
pointed to the unproductive thread. :P But I think you can take the
similarity of our patches and commit messages as my endorsement of
5a02966. :)
-Peff
prev parent reply other threads:[~2013-01-02 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 4:12 Test failures with python versions when building git 1.8.1 Dan McGee
2013-01-02 5:19 ` Junio C Hamano
2013-01-02 5:45 ` Eric S. Raymond
2013-01-02 6:53 ` Jeff King
2013-01-02 7:18 ` Junio C Hamano
2013-01-02 8:59 ` Jeff King
2013-01-02 9:09 ` Joachim Schmitz
2013-01-02 14:18 ` Dan McGee
2013-01-02 16:35 ` Junio C Hamano
2013-01-02 21:25 ` Dan McGee
2013-01-02 16:34 ` Junio C Hamano
2013-01-02 20:54 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102205435.GA24810@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=b@rr-dav.id.au \
--cc=dan@archlinux.org \
--cc=esr@thyrsus.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).