From: Pete Wyckoff <pw@padd.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH V2] t9810: Do not use sed -i
Date: Wed, 2 Jan 2013 17:44:46 -0500 [thread overview]
Message-ID: <20130102224446.GA12363@padd.com> (raw)
In-Reply-To: <201301020020.38535.tboegi@web.de>
tboegi@web.de wrote on Wed, 02 Jan 2013 00:20 +0100:
> sed -i is not portable on all systems.
> Use sed with different input and output files.
> Utilize a tmp file whenever needed
>
> Added missing && at 2 places
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
One more teensy fix is needed in this hunk, following Junio's
comment about redirections going at the end:
> @@ -139,7 +140,8 @@ test_expect_success 'scrub ko files differently' '
> cd "$git" &&
> git config git-p4.skipSubmitEdit true &&
> git config git-p4.attemptRCSCleanup true &&
> - sed -i "s/^line4/line4 edit/" fileko &&
> + sed <fileko "s/^line4/line4 edit/" >fileko.tmp &&
> + mv -f fileko.tmp fileko &&
> git commit -m "fileko line4 edit" fileko &&
> git p4 submit &&
> scrub_ko_check fileko &&
I checked that the test still works with your changes.
Thanks for the cleanup!
Acked-by: Pete Wyckoff <pw@padd.com>
-- Pete
next prev parent reply other threads:[~2013-01-02 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 23:20 [PATCH V2] t9810: Do not use sed -i Torsten Bögershausen
2013-01-02 22:44 ` Pete Wyckoff [this message]
2013-01-02 23:06 ` Junio C Hamano
2013-01-03 3:08 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102224446.GA12363@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).