From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] DEFAULT_DOC_TARGET
Date: Thu, 3 Jan 2013 15:32:22 -0500 [thread overview]
Message-ID: <20130103203222.GB4632@sigill.intra.peff.net> (raw)
In-Reply-To: <1357239920-2201-1-git-send-email-gitster@pobox.com>
On Thu, Jan 03, 2013 at 11:05:18AM -0800, Junio C Hamano wrote:
> This allows things like:
>
> $ DEFAULT_DOC_TARGET=html make doc
> $ DEFAULT_DOC_INSTALL_TARGET=html make install-doc
>
> on a platform that does not have manpage viewer. Which is not very
> useful, given that you can already say
>
> $ make install-html
>
> on such a platform, and these install-$format targets will not go
> away.
I think the usefulness is that it can be set by default for a particular
uname, so people on Windows can just type "make install-doc" without
having to care about setting anything (though to be honest, I do not
even know what they build by default; maybe they do build manpages).
Except that in the original thread:
> http://thread.gmane.org/gmane.comp.version-control.git/207193/focus=207201
it became clear that to do that we would also want to hoist the uname
automagic defaults into their own file that could be read from
Documentation/Makefile.
> The real motivation behind this was to let me say:
>
> $ git checkout $some_old_fork_point
> $ DEFAULT_DOC_TARGET=git-push.1 make doc
>
> while updating the sources to the documentation for the maintainance
> track, without having to format everything else that is different
> between the old fork point and the primary branch I usually work on.
I still don't see how this is any advantage over:
make -C Documentation git-push.1
> The first one was discussed some time ago on the list and all the
> fixes mentioned on the thread already squashed in. The second one
> is merely for completeness.
I wonder...do we really need DEFAULT_DOC_INSTALL_TARGET? Why isn't it
the same as DEFAULT_DOC_TARGET? I realize that right now we build html
and manpages by default, but only install man. But then why do we bother
building html then?
-Peff
next prev parent reply other threads:[~2013-01-03 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 19:05 [PATCH v2 0/2] DEFAULT_DOC_TARGET Junio C Hamano
2013-01-03 19:05 ` [PATCH v2 1/2] Allow generating a non-default set of documentation Junio C Hamano
2013-01-03 19:05 ` [PATCH v2 2/2] Allow installing " Junio C Hamano
2013-01-03 20:32 ` Jeff King [this message]
2013-01-03 20:37 ` [PATCH v2 0/2] DEFAULT_DOC_TARGET Jeff King
2013-01-03 21:05 ` Jeff King
2013-01-03 21:07 ` Jeff King
2013-01-03 22:20 ` Junio C Hamano
2013-01-03 22:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103203222.GB4632@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).