From: Jeff King <peff@peff.net>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*"
Date: Sun, 6 Jan 2013 09:33:20 -0500 [thread overview]
Message-ID: <20130106143319.GA10690@sigill.intra.peff.net> (raw)
In-Reply-To: <50E9852F.2060005@kdbg.org>
On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote:
> Windows disallows file names that contain a star. Arrange the test setup
> to insert the file name "f*" in the repository without the corresponding
> file in the worktree.
> [...]
> - test_commit star "f*" &&
> + # insert file "f*" in the commit, but in a way that avoids
> + # the name "f*" in the worktree, because it is not allowed
> + # on Windows (the tests below do not depend on the presence
> + # of the file in the worktree)
> + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" &&
> + test_tick &&
> + git commit -m star &&
Thanks, looks obviously correct to me.
Sorry to break Windows again. It seems I learn about a new gotcha with
every patch series. :)
-Peff
next prev parent reply other threads:[~2013-01-06 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 14:07 [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Johannes Sixt
2013-01-06 14:33 ` Jeff King [this message]
2013-01-06 20:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106143319.GA10690@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).