git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Zoltan Klinger <zoltan.klinger@gmail.com>
Cc: git@vger.kernel.org, Soren Brinkmann <soren.brinkmann@xilinx.com>,
	Jens Lehmann <Jens.Lehmann@web.de>,
	Peter Collingbourne <peter@pcc.me.uk>
Subject: Re: [PATCH v4] git-clean: Display more accurate delete messages
Date: Sun, 6 Jan 2013 15:40:22 -0800	[thread overview]
Message-ID: <20130106234022.GB3823@elie.Belkin> (raw)
In-Reply-To: <1357514219-16102-1-git-send-email-zoltan.klinger@gmail.com>

Zoltan Klinger wrote:

>   $ git clean -fd
>   Removing tracked_dir/some_untracked_file
>   Removing untracked_file
>   Removing untracked_foo/
>   Removing untracked_some.git/
>
> The message displayed to the user is slightly misleading. The foo/
> directory has not been removed because of foo/frotz.git still exists.
> On the other hand the subdirectories 'bar' and 'emptydir' have been
> deleted but they're not mentioned anywhere. Also, untracked_some.git
> has not been removed either.
[...]
> Consider the output of the improved version:
>
>   $ git clean -fd
>   Removing tracked_dir/some_untracked_file
>   Removing untracked_file
>   warning: ignoring untracked git repository untracked_foo/frotz.git
>   Removing untracked_foo/bar
>   Removing untracked_foo/emptydir
>   warning: ignoring untracked git repository untracked_some.git/

Thanks, this looks like a nice improvement.

I wonder whether it's possible to make the output more consistent,
as in:

	Removing tracked_dir/some_untracked_file
	Removing untracked_file
	Skipping repository untracked_foo/frotz.git
	Removing untracked_foo/bar
	Removing untracked_foo/emptydir
	Skipping repository untracked_some.git

or similar.  What do you think?

Thanks,
Jonathan

  reply	other threads:[~2013-01-06 23:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-06 23:16 [PATCH v4] git-clean: Display more accurate delete messages Zoltan Klinger
2013-01-06 23:40 ` Jonathan Nieder [this message]
2013-01-10  1:01   ` Zoltan Klinger
2013-01-10  2:56 ` Junio C Hamano
2013-01-10 10:41   ` Zoltan Klinger
2013-01-10 17:45     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130106234022.GB3823@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=peter@pcc.me.uk \
    --cc=soren.brinkmann@xilinx.com \
    --cc=zoltan.klinger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).