From: John Keeping <john@keeping.me.uk>
To: Manlio Perillo <manlio.perillo@gmail.com>
Cc: Marc Khouzam <marc.khouzam@ericsson.com>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"szeder@ira.uka.de" <szeder@ira.uka.de>,
"felipe.contreras@gmail.com" <felipe.contreras@gmail.com>
Subject: Re: [PATCH v4] git-completion.bash: add support for path completion
Date: Tue, 8 Jan 2013 18:05:18 +0000 [thread overview]
Message-ID: <20130108180518.GO6440@serenity.lan> (raw)
In-Reply-To: <50EC5D41.6030209@gmail.com>
On Tue, Jan 08, 2013 at 06:54:09PM +0100, Manlio Perillo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Il 05/01/2013 21:23, Marc Khouzam ha scritto:
>> [...]
>> 4- Completion choices include their entire path, which is not what bash does by default. For example:
>>> cd git/contrib
>>> ls completion/git-<tab>
>> git-completion.bash git-completion.tcsh git-completion.zsh git-prompt.sh
>> but
>>> git rm completion/git-<tab>
>> completion/git-completion.bash completion/git-completion.tcsh completion/git-completion.zsh completion/git-prompt.sh
>> notice the extra 'completion/' before each completion. This can get pretty large when completing with
>> many directory prefixes. The current tcsh completion has the same problem which I couldn't fix. However, I am
>> not sure if it can be fixed for bash.
>>
>> I personally don't think this is regression, just an slight annoyance.
>>
>
> After some searching, I found how this is supposed to be done.
> It is possible to use the -o filenames option to tell Bash completion
> that "the compspec generates filenames, so it can perform any
> filename-specific processing".
>
> Unfortunately this option must be passed to the complete builtin
> command, and we can not do this, since the comspec not always contains
> filenames.
You should also be able to pass it to 'compopt' during completion in
order to change the behaviour for only the current completion.
John
next prev parent reply other threads:[~2013-01-08 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 16:54 [PATCH v4] git-completion.bash: add support for path completion Manlio Perillo
2012-12-21 17:59 ` Junio C Hamano
2012-12-21 19:02 ` Manlio Perillo
2013-01-04 21:25 ` Marc Khouzam
2013-01-04 23:20 ` Junio C Hamano
2013-01-05 6:27 ` Junio C Hamano
2013-01-05 20:23 ` Marc Khouzam
2013-01-05 21:27 ` Manlio Perillo
2013-01-06 18:39 ` Manlio Perillo
2013-01-07 13:43 ` Manlio Perillo
2013-01-07 15:26 ` Marc Khouzam
2013-01-08 17:54 ` Manlio Perillo
2013-01-08 18:05 ` John Keeping [this message]
2013-01-08 18:28 ` Manlio Perillo
2013-01-06 18:00 ` Manlio Perillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108180518.GO6440@serenity.lan \
--to=john@keeping.me.uk \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=manlio.perillo@gmail.com \
--cc=marc.khouzam@ericsson.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).