Re: about vim contrib support

[Jeff King <peff@peff.net>]

On Thu, Jan 10, 2013 at 12:17:31PM +0100, Manlio Perillo wrote:

> In the contrib/vim/README file there are instructions about how to setup
> git support with Vim builtin git syntax files.
> 
> However these instructions seems to be redundant, since the system
> filetype.vim file already have the autocmd rules.

What version of vim do you have? As the README says, version 7.2 and on
come with the files already, and you do not need to do anything. If you
have an older version that does not ship with them, and you are pulling
them down directly from the URLs provided, then your vim probably does
not already have them in its stock filetype.vim.

> The only issue I found is with:
> 
> autocmd BufNewFile,BufRead .msg.[0-9]*
> 	\ if getline(1) =~ '^From.*# This line is ignored.$' |
> 	\   setf gitsendemail |
> 	\ endif
> 
> It should be:
> 
> autocmd BufNewFile,BufRead [0-9]*.patch

It looks like .msg.[0-9] was originally used for send-email cover
letters, and was changed to .gitsendemail.msg.* by commit eed6ca7. I
think your [0-9]*.patch would match something else entirely (though it
is still broken, of course, as .msg.* does not exist anymore).

I'd argue that we should just remove contrib/vim at this point. It has
no actual files in it, only pointers to vim.org for pre-7.2 vim users.
And that version was released in 2008, so the README is helping almost
nobody at this point (if you are on an ancient platform, and are an avid
enough vim user to download the syntax files, I suspect you would simply
install a newer version of vim).

> IMHO it should contain some other checks, to make sure it is a patch
> generated by git format-patch, and not, as an example, a plain patch or
> a Mercurial patch.
> 
> By the way: I don't understand the purpose of gitsendemail syntax.
> On my system it does not highlight the diff.

As far as I can tell, it is for cover letters, not for patches. Patches
should already be handled by existing RFC822-message highlighting.

-Peff