From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Manlio Perillo <manlio.perillo@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] contrib/vim: simplify instructions for old vim support
Date: Thu, 10 Jan 2013 16:34:27 -0500 [thread overview]
Message-ID: <20130110213427.GA26138@sigill.intra.peff.net> (raw)
In-Reply-To: <20130110205427.GG16532@google.com>
On Thu, Jan 10, 2013 at 12:54:27PM -0800, Jonathan Nieder wrote:
> Rely on the upstream filetype.vim instead of duplicating its rules in
> git's instructions for syntax highlighting support on pre-7.2 vim
> versions.
>
> The result is a shorter contrib/vim/README. More importantly, it lets
> us punt on maintenance of the autocmd rules.
>
> So now when we fix the upstream gitsendemail rule in light of commit
> eed6ca7, new git users stuck on old vim reading contrib/vim/README can
> automagically get the fix without any further changes needed to git.
>
> Once the world has moved on to vim 7.2+ completely, we can get rid of
> these instructions, but for now if they are this simple it's
> effortless to keep them.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Jeff King wrote:
>
> > I'd argue that we should just remove contrib/vim at this point. It has
> > no actual files in it, only pointers to vim.org for pre-7.2 vim users.
>
> I think that's reasonable. Of course we can still discuss enhancements
> to the vim support on this list, but ultimately it's easiest to
> distribute and document such work upstream in the usual way for vim
> plugins.
>
> How about this patch?
Yeah, I think this makes sense. I'd be fine with removing it entirely,
but it doesn't hurt to err on the conservative side and leave it there.
It's not like it's generating a huge maintenance burden, and with your
patch, there is even less to maintain.
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2013-01-10 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 11:17 about vim contrib support Manlio Perillo
2013-01-10 11:39 ` Jeff King
2013-01-10 11:51 ` Manlio Perillo
2013-01-10 13:36 ` Jeff King
2013-01-10 20:54 ` [PATCH] contrib/vim: simplify instructions for old vim support Jonathan Nieder
2013-01-10 21:34 ` Jeff King [this message]
2013-01-10 23:08 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110213427.GA26138@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=manlio.perillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).