From: Ross Lagerwall <rosslagerwall@gmail.com>
To: git@vger.kernel.org
Cc: "Jean-Noël AVILA" <avila.jn@gmail.com>
Subject: git grep performance regression
Date: Mon, 14 Jan 2013 22:38:00 +0000 [thread overview]
Message-ID: <20130114223800.GA12708@hobo.wolfson.cam.ac.uk> (raw)
Hi,
I have noticed a performance regression in git grep between v1.8.1 and
v1.8.1.1:
On the kernel tree:
For git 1.8.1:
$ time git grep foodsgsg
real 0m0.158s
user 0m0.290s
sys 0m0.207s
For git 1.8.1.1:
$ time /tmp/g/bin/git grep foodsgsg
real 0m0.501s
user 0m0.707s
sys 0m0.493s
A bisect seems to indicate that it was introduced by 94bc67:
commit 94bc671a1f2e8610de475c2494d2763355a99f65
Author: Jean-Noël AVILA <avila.jn@gmail.com>
Date: Sat Dec 8 21:04:39 2012 +0100
Add directory pattern matching to attributes
The manpage of gitattributes says: "The rules how the pattern
matches paths are the same as in .gitignore files" and the gitignore
pattern matching has a pattern ending with / for directory matching.
This rule is specifically relevant for the 'export-ignore' rule used
for git archive.
Signed-off-by: Jean-Noel Avila <jn.avila@free.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Regards
--
Ross Lagerwall
next reply other threads:[~2013-01-14 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 22:38 Ross Lagerwall [this message]
2013-01-15 2:46 ` git grep performance regression Duy Nguyen
2013-01-15 4:38 ` Duy Nguyen
2013-01-15 7:36 ` Ross Lagerwall
2013-01-15 2:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114223800.GA12708@hobo.wolfson.cam.ac.uk \
--to=rosslagerwall@gmail.com \
--cc=avila.jn@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).